Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged #635 Causing Downstream issue in Collection cisco.ios #639

Closed
happly opened this issue May 24, 2024 · 5 comments
Closed

Merged #635 Causing Downstream issue in Collection cisco.ios #639

happly opened this issue May 24, 2024 · 5 comments
Labels
bug This issue/PR relates to a bug. has_pr This issue has an associated PR.

Comments

@happly
Copy link

happly commented May 24, 2024

SUMMARY

Installing collection cisco.ios v8.0.0 pulls in ansible.netcommon by the logic ansible.netcommon: >=6.1.0 seen on the dependencies page.

Since the merging of #635 and release of v6.1.2, this is the latest dependency pulled in during the installation of cisco.ios collection.

When ansible.netcommon v6.1.2 is used with cisco.ios.ios_interfaces modules the following error is returned:

{
  "module_stdout": "",
  "module_stderr": "edit_config() got an unexpected keyword argument 'err_responses'",
  "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
  "_ansible_no_log": false,
  "changed": false
}

Note the mention of unexpected kwargs 'err_responses'; this argument seems to have been introduced in #635 .

When ansible.netcommon is pinned to v6.1.1, cisco.ios.ios_interfaces completes successfully.

ISSUE TYPE
  • Bug Report
COMPONENT NAME
ANSIBLE VERSION
ansible [core 2.15.12]
  config file = None
  configured module search path = ['/runner/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.9/site-packages/ansible
  ansible collection location = /runner/requirements_collections:/runner/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/local/bin/ansible
  python version = 3.9.18 (main, Jan 24 2024, 00:00:00) [GCC 11.4.1 20231218 (Red Hat 11.4.1-3)] (/usr/bin/python3)
  jinja version = 3.1.4
  libyaml = True
COLLECTION VERSION
# /runner/requirements_collections/ansible_collections
Collection        Version
----------------- -------
ansible.netcommon 6.1.2  

# /runner/requirements_collections/ansible_collections
Collection Version
---------- -------
cisco.ios  8.0.0  

# /runner/requirements_collections/ansible_collections
Collection    Version
------------- -------
ansible.utils 4.1.0  
CONFIGURATION
[0;33mANSIBLE_FORCE_COLOR(env: ANSIBLE_FORCE_COLOR) = True�[0m
�[0;33mCOLLECTIONS_PATHS(env: ANSIBLE_COLLECTIONS_PATH) = ['/runner/requirements_collections', '/runner/.ansible/collections', '/usr/share/ansible/collections']�[0m
�[0;33mCONFIG_FILE() = None�[0m
�[0;33mDEFAULT_CALLBACK_PLUGIN_PATH(env: ANSIBLE_CALLBACK_PLUGINS) = ['/usr/local/lib/python3.9/site-packages/ansible_runner/display_callback/callback']�[0m
�[0;33mDEFAULT_ROLES_PATH(env: ANSIBLE_ROLES_PATH) = ['/runner/requirements_roles', '/runner/.ansible/roles', '/usr/share/ansible/roles', '/etc/ansible/roles']�[0m
�[0;33mDEFAULT_STDOUT_CALLBACK(env: ANSIBLE_STDOUT_CALLBACK) = awx_display�[0m
�[0;33mHOST_KEY_CHECKING(env: ANSIBLE_HOST_KEY_CHECKING) = False�[0m
�[0;33mINVENTORY_UNPARSED_IS_FAILED(env: ANSIBLE_INVENTORY_UNPARSED_FAILED) = True�[0m
�[0;33mRETRY_FILES_ENABLED(env: ANSIBLE_RETRY_FILES_ENABLED) = False�[0m
OS / ENVIRONMENT

AWX EE quay.io/ansible/awx-ee:latest (sha256:e9dc6bd5952a3d2e87bc1a3e5c12b88e9ba62e97a2e7b6beb8a80a597f217e9c)

Cisco IOS XE Software, Version 17.09.04a
Cisco IOS Software [Cupertino], Catalyst L3 Switch Software (CAT9K_IOSXE), Version 17.9.4a, RELEASE SOFTWARE (fc3)

STEPS TO REPRODUCE
  • Install cisco.ios v8.0.0
  • Run playbook against switch
- name: Change Port Description
  hosts: all
  gather_facts: false
  tasks:
    - name: Change Description
      become: true
      cisco.ios.ios_interfaces:
        config:
          - name: "GigabitEthernet1/0/46"
            description: "beep boop bop"
EXPECTED RESULTS

Cisco interface port description modified

ACTUAL RESULTS
{
  "module_stdout": "",
  "module_stderr": "edit_config() got an unexpected keyword argument 'err_responses'",
  "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
  "_ansible_no_log": false,
  "changed": false
}
@happly
Copy link
Author

happly commented May 24, 2024

I create a Bug Report in the cisco.ios repository as well, as I am not sure whether the fix lies upstream or downstream.

@NilashishC
Copy link
Contributor

@happly This has been fixed with #640. We will do a netcommon release soon.

@NilashishC NilashishC added bug This issue/PR relates to a bug. has_pr This issue has an associated PR. labels May 28, 2024
@happly
Copy link
Author

happly commented May 28, 2024

@NilashishC Thank you for the quick fix!

@NilashishC
Copy link
Contributor

This has been fixed with ansible.netcommon v6.1.3. Thanks!

@happly
Copy link
Author

happly commented May 30, 2024

Confirming that 6.1.3 resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug. has_pr This issue has an associated PR.
Projects
None yet
Development

No branches or pull requests

2 participants