-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - feat/1078: Extension: Permission improvements #1142
Draft
jurevans
wants to merge
6
commits into
main
Choose a base branch
from
feat/1078-approve-chain-id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurevans
force-pushed
the
feat/1078-approve-chain-id
branch
3 times, most recently
from
September 30, 2024 10:38
c49fa7a
to
22ba6bf
Compare
jurevans
changed the title
WIP: feat/1078 - Extension: Chain ID approval
WIP - feat/1078: Extension: Chain ID approval
Sep 30, 2024
jurevans
force-pushed
the
feat/1078-approve-chain-id
branch
3 times, most recently
from
October 4, 2024 17:23
82488eb
to
e0cc486
Compare
jurevans
force-pushed
the
feat/1078-approve-chain-id
branch
6 times, most recently
from
October 24, 2024 15:05
5997a9f
to
436ce47
Compare
jurevans
changed the title
WIP - feat/1078: Extension: Chain ID approval
WIP - feat/1078: Extension: Permission improvements
Oct 24, 2024
jurevans
force-pushed
the
feat/1078-approve-chain-id
branch
4 times, most recently
from
October 29, 2024 12:24
33736ad
to
dfb6ebc
Compare
jurevans
force-pushed
the
feat/1078-approve-chain-id
branch
4 times, most recently
from
November 6, 2024 16:06
f6383fd
to
7524509
Compare
jurevans
force-pushed
the
feat/1078-approve-chain-id
branch
from
November 8, 2024 13:09
7524509
to
8a652f3
Compare
jurevans
force-pushed
the
feat/1078-approve-chain-id
branch
from
November 19, 2024 11:09
8a652f3
to
57a8006
Compare
2 tasks
jurevans
force-pushed
the
feat/1078-approve-chain-id
branch
from
November 20, 2024 13:01
57a8006
to
9249c06
Compare
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1078
Notes
chainId
to any extension connection functionality - inIntegrations
, this will be optional, but runtime-checked inNamada
integration)