Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: feat/1078 - Extension - Enable chain approval #1091

Closed
wants to merge 1 commit into from
Closed

WIP: feat/1078 - Extension - Enable chain approval #1091

wants to merge 1 commit into from

Conversation

jurevans
Copy link
Collaborator

@jurevans jurevans commented Sep 11, 2024 •
edited
Loading

Resolves #1078

  • When approving connection, if interface is attempting to use a different chain ID, alert user, and if approved, save this in extension
  • When the interface is later connected to an indexer that returns a different chain ID, display a new approval to allow updating the extension

@jurevans jurevans self-assigned this Sep 11, 2024
@jurevans jurevans force-pushed the feat/1078-extension-chain-id-on-connect branch 5 times, most recently from 7e78e0e to 3a84499 Compare September 14, 2024 15:41
@jurevans jurevans force-pushed the feat/1078-extension-chain-id-on-connect branch 2 times, most recently from faac03e to eb38b75 Compare September 24, 2024 14:28
@jurevans jurevans force-pushed the feat/1078-extension-chain-id-on-connect branch from eb38b75 to f127d4f Compare November 19, 2024 11:09
@jurevans
Copy link
Collaborator Author

Closing in favor of #1142

@jurevans jurevans closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jurevans jurevans

Labels
App: Extension feature UI: Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extension: Allow interface to specify chain ID when connecting, update when approved
1 participant
@jurevans