-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiarch Playnite Web Docker Images #326
Conversation
Yarn publish target has been updated to build for all available architectures by inspecting engine on runtime: Github Actions have been updated so that they setup QEMU and configure it for |
@andrew-codes Can you provide some guidance on how to best test these changes? |
@cvele In terms of testing, the GitHub runner that is being used is currently published to a private registry. The image is defined by this project, https://github.com/andrew-codes/home-automation/tree/main/apps/github-action-runners (see the src directory for the Dockerfile). You will need to build that image locally to test with until I get it published to ghcr.io. I will work on doing this soon. Note the |
Based on the new error message, I think the remaining work is to enable multi-arch builds on the runner; specifically, enabling the containerd image store on the runner. It is not clear to me what I need to do to accomplish this, so any advice or guidance is appreciated. Thanks for your contribution! |
Feel free to revert the commit: 0fa413d. I am taking care of that in a separate PR now. |
Reverted: Additionally added some parameters to Buildx setup which should enable the containerd image store which supports multi-platform builds. |
I'm not familiar with the error in the build. @cvele , let me know how I can support in resolving this. Thanks! |
Also, I mis-spoke, I am not using a custom runner image in this repo. I can re-run the PR once the current error is updated. Thanks! |
- Updated publish_images job in GitHub Actions workflow - Enabled containerd image store in docker/setup-buildx-action to support multi-platform builds - Adjusted driver-opts to include necessary options for containerd Resolves multi-platform build error in CI pipeline.
WIP
Goal is to release Docker images supporting multiple architectures, primarily
arm64
. While this is not a blocker for #319 it's one for personal use-case.