Playnite Web components as HASS addons #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has a soft dependency on: #326 |
andrew-codes
requested changes
May 28, 2024
|
Also, @cvele , do you mind signing your commits? I'd prefer to have commits signed that enter the repo. Let me know if I can be any assistance in setting this up. Thanks! |
|
I am going to try to update this sometime today. |
package dev or specific version of images for use as HASS add-ons
PRs from external contributors do not have the PLAYNITE_TOOLBOX_URL available to them. For this reason, ci will fail to to package. Instead, check if the extension can be compiled and assume a successful compilation can be packaged.
andrew-codes
changed the title
andrew-codes
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andrew-codes This PR is highly opinionated regarding directory structure and naming conventions. It also assumes that different Docker images will be built for the add-ons, but based on the base Playnite web image. The main reason for this approach is the inclusion of Bashio, which is required to read configuration parameters set in Home Assistant.