Zephyr opanamp rsc dev 1 #1

alxlastur · 2024-09-10T12:28:34Z

No description provided.

Added the imx8mp_evk_mimx8ml8_m7.conf and imx8mp_evk_mimx8ml8_m7.overlay files in the boards directory. Signed-off-by: Alexandru Lastur <[email protected]>

Added the imx93_evk_mimx9352_m33.conf and imx93_evk_mimx9352_m33.overlay files in the boards directory Signed-off-by: Alexandru Lastur <[email protected]>

drivers: ipm: ipm_imx.c Handles the status of Mailbox Unit RX register when the target is SOC_MIMX9352. This change is required as the imx93 mailbox register map have a different structure. Signed-off-by: Alexandru Lastur <[email protected]>

Added a structure which will store and pass it to mailbox_notify() the channel id of the Linux messaging unit during the platform_ipm_callback(). This change was necessary, because until now the zephyr target (in openamp_rsc sample) would always notify the Linux target with a channel id of 0, even if Linux would send a notification on another channel differnt than 0. For example in imx8mp_evk cortex m7 and imx93_evk cortex m33 BSP, the .dts is configuring the messaging unit to use channel 1. Signed-off-by: Alexandru Lastur <[email protected]>

Added a resource table section named '.resource_table' because Linux remoteproc driver is parsingthe elf file, and will look for that section named '.resource_table'. Added this configuration in include/zephyr/arch/arm/cortex_m/scripts/linker.ld as it should benefits all the Cortex M cofiguration when using th sample opanamp_rsc. linker: imx8mp_evk m7 linke.ld: removed CONFIG_OPENAMP_RSC_TABLE Removed CONFIG_OPENAMP_RSC_TABLE from soc/nxp/imx/imx8m/m7 as it is already configured in the general linker.ld file Signed-off-by: Alexandru Lastur <[email protected]>

dbaluta · 2024-09-10T12:59:30Z

samples/subsys/ipc/openamp_rsc_table/boards/imx8mp_evk_mimx8ml8_m7.conf

@@ -0,0 +1,9 @@
+CONFIG_LOG_PRINTK=n
+CONFIG_IPM_IMX_MAX_DATA_SIZE_16=n


Since 8mp support doesn't depend on other patches lets send this as a separate Pull request.

Commit message should look like this:

sample: open_amp_rsc_table: Add support for imx8mp_evk M7 core This enables openamp_rsc_table sample for imx8mp_evk on M7 core

dbaluta · 2024-09-10T13:02:36Z

include/zephyr/arch/arm/cortex_m/scripts/linker.ld

@@ -1,5 +1,6 @@
 /*
 * Copyright (c) 2013-2014 Wind River Systems, Inc.
+ * Copyright 2024 NXP


Reformat commit message as follows:

linker: Move resource_table to generic cortex M linker file In order to avoid copying the '.resource_table' section each time we add support for a new board lets have this section in the generic linker file and enable it using CONFIG_OPENAMP_RSC_TABLE.

A commit should specifically state WHY the change is needed. In this case the change is needed because we want to avoid copying the linker section every time we want to add support for a new board.

dbaluta · 2024-09-10T13:04:49Z

samples/subsys/ipc/openamp_rsc_table/boards/imx93_evk_mimx9352_m33.conf

@@ -0,0 +1,9 @@
+CONFIG_LOG_PRINTK=n


Commit message here should be similiar with the one from 8mp_evk

dbaluta · 2024-09-10T13:09:00Z

samples/subsys/ipc/openamp_rsc_table/src/main_remote.c

@@ -1,5 +1,6 @@
 /*


We shouldn't start a commit message with an explanation of what the code DOES. But with an explanation of WHY the code is needed.

Also try to use natural language when explaining things. For the rest people can just inspect the code.

So, let's reformat the commit message as follows:

samples: openamp_rsc_table: Don't hardcode notification channel ID to 0 Currently, Zephyr is always sending back notifications to AP (e.g Linux in our case) on channel 0. But this currently doesn't work if Linux uses other channel id for communication. So, save the channel id used by Linux and use it to send back replies.

should we put this in the same PR for imx8mp? Asking because the example wouldn't work if we don't modify the channel

@alxlastur yes, that makes sense.

Also, by mistake the first time I made the PR, I made it over the one from the upstream zephyr github (not nxp one) and closed it immediately. But someone put some comments even if it was closed:

Then realised it was closed.

do you have a link for this?

@dbaluta zephyrproject-rtos#78228

OK, lets go on with the plan we already have. And once you add the PR I will copy paste @arnopo'
s comment and restart the discussion from there.

ok @dbaluta , then I will make a PR for imx8mp with 2 commits:

First commit contains: samples/subsys/ipc/openamp_rsc_table/boards/imx8mp_evk_mimx8ml8_m7.conf and samples/subsys/ipc/openamp_rsc_table/boards/imx8mp_evk_mimx8ml8_m7.overlay

Second commit contain samples/subsys/ipc/openamp_rsc_table/src/main_remote.c

Right?

Yes. Make sure you add proper commit messages as I previously commented.

dbaluta · 2024-09-10T13:11:59Z

dts/arm/nxp/nxp_imx93_m33.dtsi

+			compatible = "nxp,imx-mu";
+			reg = <0x44220000 DT_SIZE_K(64)>;
+			interrupts = <21 0>;
+		};


This should be moved in the same patch with the one adding overlays for imx93 M33 core as it is a change related to DTS.

dbaluta · 2024-09-10T13:12:48Z

drivers/ipm/ipm_imx.c

 	status_reg = base->SR >>= MU_SR_RFn_SHIFT;
+#endif

 	for (id = CONFIG_IPM_IMX_MAX_ID_VAL; id >= 0; id--) {


This should be a standalone patch explaining that MU register layout has changed or imx93 and we need to reverse the bits in order to work.

This would be the most problematic change to get in. but lets sending it like this and hope for the best.

@alxlastur is it possible to do this change in NXP hal - in fsl_mu.c?
When taking the status_reg this should be already shifted for i.mx93.

@iuliana-prodan , as far as I see I don't think so. The isr is defined in ipx_imx.c:

I see no ISR in fsl_mu.c or fsl_mu.h

I was thinking to get the status register from fsl_mu by writing a function that does what you have above.
Here, like we have the MU_GetStatusFlags(), something like MU_GetStatusRegister().
I have to take a look on imx93 MU :)

Yes. In this case it needs a MU_GetStatusRegister() that works for for all platforms. So MU_GetStatusRegister() should work for imx93 and imx8mp.

dbaluta · 2024-09-10T13:13:22Z

dts/arm/nxp/nxp_imx93_m33.dtsi

@@ -95,6 +95,12 @@
 			clocks = <&ccm IMX_CCM_LPUART2_CLK 0x6c 24>;
 			status = "disabled";
 		};
+
+		mu1: mu1@44220000 {


This should be mu1: mu@4422000....

iuliana-prodan · 2024-09-10T13:30:40Z

samples/subsys/ipc/openamp_rsc_table/boards/imx93_evk_mimx9352_m33.conf

+CONFIG_LOG=y
+CONFIG_LOG_BACKEND_UART=y
+CONFIG_LOG_DEFAULT_LEVEL=0
+CONFIG_LOG_MODE_MINIMAL=y


add a newline here

iuliana-prodan · 2024-09-10T13:31:13Z

samples/subsys/ipc/openamp_rsc_table/boards/imx93_evk_mimx9352_m33.overlay

+		reg = <0xA4000000 0x120000>;
+	};
+
+	mu1{


add a space between mu1 and {

alxlastur added 5 commits September 9, 2024 20:50

samples: subsystem/ipc/opanamp_rsc: Add imx8mp_evk cortex m7

5297cc8

Added the imx8mp_evk_mimx8ml8_m7.conf and imx8mp_evk_mimx8ml8_m7.overlay files in the boards directory. Signed-off-by: Alexandru Lastur <[email protected]>

samples: subsystem/ipc/opanamp_rsc: Add imx93_evk cortex m33

2975b02

Added the imx93_evk_mimx9352_m33.conf and imx93_evk_mimx9352_m33.overlay files in the boards directory Signed-off-by: Alexandru Lastur <[email protected]>

dbaluta reviewed Sep 10, 2024

View reviewed changes

iuliana-prodan reviewed Sep 10, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Zephyr opanamp rsc dev 1 #1

Zephyr opanamp rsc dev 1 #1

alxlastur commented Sep 10, 2024

dbaluta Sep 10, 2024 •

edited

Loading

dbaluta Sep 10, 2024 •

edited

Loading

dbaluta Sep 10, 2024

dbaluta Sep 10, 2024 •

edited

Loading

alxlastur Sep 16, 2024

dbaluta Sep 16, 2024

alxlastur Sep 16, 2024 •

edited

Loading

dbaluta Sep 16, 2024

alxlastur Sep 16, 2024

dbaluta Sep 16, 2024

alxlastur Sep 16, 2024

dbaluta Sep 16, 2024

dbaluta Sep 10, 2024

dbaluta Sep 10, 2024

iuliana-prodan Sep 10, 2024

alxlastur Sep 10, 2024

iuliana-prodan Sep 10, 2024

alxlastur Sep 10, 2024

dbaluta Sep 10, 2024

iuliana-prodan Sep 10, 2024

iuliana-prodan Sep 10, 2024

		@@ -0,0 +1,9 @@
		CONFIG_LOG_PRINTK=n
		CONFIG_IPM_IMX_MAX_DATA_SIZE_16=n

Zephyr opanamp rsc dev 1 #1

Are you sure you want to change the base?

Zephyr opanamp rsc dev 1 #1

Conversation

alxlastur commented Sep 10, 2024

dbaluta Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

dbaluta Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbaluta Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alxlastur Sep 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbaluta Sep 10, 2024 •

edited

Loading

dbaluta Sep 10, 2024 •

edited

Loading

dbaluta Sep 10, 2024 •

edited

Loading

alxlastur Sep 16, 2024 •

edited

Loading