Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MO-322 adding check-types command to base monorepo targets as well as… #968

Conversation

ryan-richards-aligent
Copy link

  • Adding 'check-types' command to service generator and monorepo targets.
  • Adding to library generator section of README to detail limitations of the nx lib generator

… the service generator. changing the readme to inform users of library generator limitations
@ryan-richards-aligent ryan-richards-aligent requested review from tvhees and a team as code owners June 6, 2024 07:22
@ryan-richards-aligent ryan-richards-aligent requested review from crispy101 and removed request for a team June 6, 2024 07:22
Copy link
Collaborator

@tvhees tvhees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch that we should update project.json for the generator itself as well.

Just a bit of modification required.

nx.json Outdated Show resolved Hide resolved
tools/serverless-plugin/project.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
…it is handled on nx.json level, and removing command details from nx.json
@ryan-richards-aligent
Copy link
Author

Made the relevant changes based on feedback @tvhees

@tvhees tvhees merged commit 5d40b62 into aligent:main Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants