Merge pull request #968 from ryan-richards-aligent/feature/MO-322-add…

…-check-types-command-to-service-generator MO-322 adding check-types command to base monorepo targets as well as…
aligent · Jun 7, 2024 · 5d40b62 · 5d40b62
2 parents 9f4a1ab + e6569a9
commit 5d40b62
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -44,6 +44,18 @@ Libraries are generated by `@nx/js` plugin. For more information, check out thei
 
 `npx nx g library <library-name>`
 
+Shared library will need to have the `check-types` command added manually to ensure proper type checking. This is because the the `@nx/js` plugin does not add it by default.
+```json
+"check-types": {
+    "executor": "nx:run-commands",
+    "options": {
+        "cwd": "{projectRoot}",
+        "color": true,
+        "command": "tsc --noEmit --pretty"
+    },
+}
+```
+
 ### General Nx. commands
 
 Below are some example of general Nx. commands. For more information, check out their [document](https://nx.dev/packages/nx/documents).

diff --git a/nx.json b/nx.json
@@ -20,6 +20,9 @@
             "outputs": ["{projectRoot}/.serverless"],
             "cache": true
         },
+        "check-types": {
+            "cache": true
+        },
         "lint": {
             "inputs": [
                 "default",

diff --git a/tools/serverless-plugin/project.json b/tools/serverless-plugin/project.json
@@ -15,6 +15,14 @@
                 "generatePackageJson": true
             }
         },
+        "check-types": {
+            "executor": "nx:run-commands",
+            "options": {
+                "cwd": "{projectRoot}",
+                "color": true,
+                "command": "tsc --noEmit --pretty"
+            }
+        },
         "lint": {
             "executor": "@nx/linter:eslint",
             "outputs": ["{options.outputFile}"],

diff --git a/tools/serverless-plugin/src/generators/service/generator.ts b/tools/serverless-plugin/src/generators/service/generator.ts
@@ -35,6 +35,14 @@ export async function serviceGenerator(
             remove: {
                 ...buildRunCommandConfig(projectRoot, 'sls remove'),
             },
+            'check-types': {
+                'executor': 'nx:run-commands',
+                'options': {
+                    'cwd': '{projectRoot}',
+                    'color': true,
+                    'command': 'tsc --noEmit --pretty'
+                }
+            },
             lint: {
                 executor: '@nx/linter:eslint',
                 outputs: ['{options.outputFile}'],