semi-fungible token #349
semi-fungible token #349
Conversation
|
@fiftyeightandeight Why is the |
- Test case files has bugs in imports - A change in token-wstx and token-usda get-decimals is questionable - Added mintFixed for now
USDA supports up to 6 decimals (https://github.com/arkadiko-dao/arkadiko/blob/master/clarity/contracts/usda-token.clar), hence. WBTC is a bit arbitrary, but I am thinking about standardising every token to 6 decimals to be consistent with STX (minor point is it might somewhat reduce errors in the last two digit decimals). |
|
@SaadTahirTintash once #324 is fixed, please let me know as we need to work through the test cases for this PR. |
|
Okay So I've added the mint function in the model but the test cases are not right for now. I am pushing the code which is subject to change from |
There was a problem hiding this comment.
I tried to keep the scope to just reviewing things related to the semi-fungible token implementation. I like how you are using SFTs to capture all yield token variations in a single contract. Very nice.
Biggest thing is that the trait does not confirm to the latest draft of the SIP.
| @@ -0,0 +1,39 @@ | |||
| (define-trait semi-fungible-token-trait | |||
There was a problem hiding this comment.
I suggest using the trait from the SIP and then defining custom features in a separate ALEX-specific trait. This trait does not conform to the current draft which could cause issues down the line. (If it is ratified as-is.)
There was a problem hiding this comment.
@SaadTahirTintash would you please help refactor this trait to reflect @MarvinJanssen 's comments?
…io/alex-v1 into feat/semi-fungible-token
|
@MarvinJanssen , as discussed, we will refactor trait to include |
…io/alex-v1 into feat/semi-fungible-token
closes #303