Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change decimals of wbtc and usda #330

Closed
fiftyeightandeight opened this issue Nov 5, 2021 · 3 comments
Closed

fix: change decimals of wbtc and usda #330

fiftyeightandeight opened this issue Nov 5, 2021 · 3 comments
Assignees

Comments

@fiftyeightandeight
Copy link
Contributor

Refer to https://github.com/alexgo-io/alex-v1-app/issues/237.
closes #313

@SaadTahirTintash
Copy link
Contributor

I've pushed the commits for the test cases of YTP, FWP and CRP for you to review the numbers.

@fiftyeightandeight
Copy link
Contributor Author

Hi @SaadTahir28 , I reviewed the numbers over the weekend, and am coming to conclusion that it is actually very hard to support zero decimals, primarily due to that we use 8-digit fixed notation for most of the calculation and, either the decimals get truncated (not something we want) or extra care needs to be given to properly handle this (not something I think that is worth pursuing).

I will ask you to help me on #349 instead.

@SaadTahirTintash
Copy link
Contributor

SaadTahirTintash commented Nov 15, 2021

Yeah exactly. I was also having these issues and thought of that it is certainly not possible because of decimal places. I will start looking into this new issue today and understand what is going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants