Fix #35 (verilator getting stuck) and add ci test #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, but I'm not interested in making any changes here to support verilator until verilator/verilator#2778 is fixed and cocotb works with the latest release version of verilator. |
|
Fair enough. Let´s keep this open, since I still think there is the buggy verilator issue you mentioned, however there is a good chance that something broke in |
alexforencich
force-pushed
the
master
branch
2 times, most recently
from
c9b4c7a to
824eba7
Compare
|
Just hit this same issue trying to run test_axi_interconnect.py using a new version of verilator (with the above mentioned bug fixed) Switching to using cocotb-bus==0.1.1 fixed the issue for me. |
|
Upstream verilator issue is verilator/verilator#3919 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #35. In addition, we should add a test case to the CI to ensure that verilator support persists. Right now, I set the environment variable
SIM=verilator, however, we should testicarusandverilatorbefore we merge this.