-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mag and e_mag values when forcediffimflux and/or forcediffimfluxunc is -99999 #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirodriguezm
requested changes
Dec 6, 2023
dirodriguezm
approved these changes
Dec 6, 2023
…elds from forced photometry and not alert
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
===========================================
- Coverage 86.38% 74.63% -11.76%
===========================================
Files 32 8 -24
Lines 1645 272 -1373
===========================================
- Hits 1421 203 -1218
+ Misses 224 69 -155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Added conditions so that when forcediffimflux = -99999 (measurement could not be computed, as described in Masci+2023) then mag is nan, and similarly for forcediffimfluxunc and e_mag. These should naturally give mag_corr, e_mag_corr and e_mag_corr_ext as nan values too. Bug was described in #316.
About this PR: