Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mag and e_mag values when forcediffimflux and/or forcediffimfluxunc is -99999 #323

Merged
merged 21 commits into from
Dec 6, 2023

Conversation

ale-munozarancibia
Copy link
Contributor

Summary of the changes

Added conditions so that when forcediffimflux = -99999 (measurement could not be computed, as described in Masci+2023) then mag is nan, and similarly for forcediffimfluxunc and e_mag. These should naturally give mag_corr, e_mag_corr and e_mag_corr_ext as nan values too. Bug was described in #316.

About this PR:

  • You added the necessary documentation for the team to understand your work.
  • You linked this PR to the corresponding issue or user story.
  • Your changes fulfill the Definition of Done of the issue or user story.
  • Your changes were tested with manual testing before being submitted.
  • Your changes were tested with automatic unit tests.
  • Your changes were tested with automatic integration tests.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51d2328) 86.38% compared to head (97da122) 74.63%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #323       +/-   ##
===========================================
- Coverage   86.38%   74.63%   -11.76%     
===========================================
  Files          32        8       -24     
  Lines        1645      272     -1373     
===========================================
- Hits         1421      203     -1218     
+ Misses        224       69      -155     
Flag Coverage Δ
unittest 74.63% <100.00%> (-11.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirodriguezm dirodriguezm merged commit 601aa68 into main Dec 6, 2023
10 of 14 checks passed
@dirodriguezm dirodriguezm deleted the fix/forcedphot_99999 branch December 6, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants