Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Prv-Candidates] Forced photometry magnitude should be replaced to NaN when value is -99999 so that correction gives NaN as well to avoid confusion #316

Closed
Tracked by #147
dirodriguezm opened this issue Dec 5, 2023 · 1 comment · Fixed by #323
Assignees
Labels
bug Something isn't working

Comments

@dirodriguezm
Copy link
Contributor

  • Correction step should give NaN (this test is already added)
  • Mag values should be NaN when reaching correction step instead of -99999 (prv-candidates parsing)
@dirodriguezm
Copy link
Contributor Author

Se decidió lo siguiente:

Prv Candidates define ZEROMAG = 100 al igual que en Correction step. Las magnitudes de fotometría forzada con valor -99999 se convierten en ZEROMAG.

En el Correction Step, se hace un filtro y se corrigen las detecciones que no tienen mag = ZEROMAG. Las que tienen mag = ZEROMAG quedan como np.inf en el proceso de corrección para luego quedar como ZEROMAG post corrección y como salida del step.

El paso a np.inf es para mantener la estructura dentro del proceso de corrección donde después se convierte todos los np.inf a ZEROMAG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
2 participants