Optimize SwiftUIWrapperView #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryankeller
force-pushed
the
bk/optimize-SwiftUIWrapperView
branch
from
77e5cee to
2fce208
Compare
bryankeller
force-pushed
the
bk/optimize-SwiftUIWrapperView
branch
from
2fce208 to
a8caca1
Compare
bryankeller
commented
Nov 9, 2024
| public override var isHidden: Bool { | ||
| didSet { | ||
| if isHidden { | ||
| hostingController.rootView = AnyView(EmptyView()) |
There was a problem hiding this comment.
not ideal, but way faster than the previous strategy of giving every view an ID
There was a problem hiding this comment.
We could also add an API in the future to opt-out of this behavior if someone doesn't need onAppear or onDisappear callbacks in their views, which would get them back ~20% CPU usage when scrolling fast 🤯
bryankeller
commented
Nov 9, 2024
| } | ||
|
|
||
| // MARK: Fileprivate | ||
|
|
||
| fileprivate var contentAndID: ContentAndID { | ||
| didSet { | ||
| hostingController.rootView = .init(content: contentAndID.content, id: contentAndID.id) | ||
| hostingController.rootView = AnyView(contentAndID.content) |
There was a problem hiding this comment.
I profiled and there was no perf hit from switching to AnyView
This was referenced Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR significantly reduces CPU use for people using SwiftUI views for their calendar items by making 2 optimizations:
UIHostingControlleras a child view controller, and just work with its hosting view directlyonAppearandonDisappearcallbacks - instead, set a hidden view's to just display anEmptyViewTogether, these changes reduce CPU use by 35-40% when scrolling fast.
Related Issue
#299
Motivation and Context
Performance improvements.
How Has This Been Tested
Example app
Types of changes
Checklist