Improve SwiftUIWrapperView performance #322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is a follow-up to #320.
I made the mistake of only testing with a simple view during my performance investigation, which led me to believe that setting the hosting controller's
rootView
to anAny(EmptyView())
when it went off screen was the best way to get appearance callbacks to work. Although that approach was faster than removing the hosting controller's view from the hierarchy for a very simple view, it gets slower the more complicated the view is. Even a simpleText
with a background shape is 10% slower if we set therootView
to anAny(EmptyView())
vs. just removing the hosting controller's view from the hierarchy.I'm assuming this is the case because it's more expensive to tear down and set up a complicated view from scratch vs. whatever price we pay for removing and adding subviews dynamically.
Related Issue
N/A
Motivation and Context
Performance improvements
How Has This Been Tested
Example app, Airbnb app