Refactor dev #13
+3,658
−7,071
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| DEFAULT_MODE_OF_TRANSFERS = [ | ||
| { | ||
| "mode": "IMPS", | ||
| "minimum_limit": 0, | ||
| "maximum_limit": 200000, | ||
| "start_time": "0:00:00", | ||
| "end_time": "23:59:59", | ||
| "disabled": 1, | ||
| "priority": "1", | ||
| }, | ||
| { | ||
| "mode": "RTGS", | ||
| "minimum_limit": 200000, | ||
| "maximum_limit": 50000000, | ||
|
There was a problem hiding this comment. Make 50 Crore as the upper limit, beyond that LEI number is required. |
||
| "start_time": "0:00:00", | ||
| "end_time": "23:59:59", | ||
| "disabled": 1, | ||
| "priority": "1", | ||
| }, | ||
| { | ||
| "mode": "NEFT", | ||
| "minimum_limit": 0, | ||
| "maximum_limit": 100000000000, | ||
|
There was a problem hiding this comment. Make 50 Crore as the upper limit, beyond that LEI number is required. |
||
| "start_time": "0:00:00", | ||
| "end_time": "23:59:59", | ||
| "disabled": 1, | ||
| "priority": "1", | ||
| }, | ||
| { | ||
| "mode": "A2A/FT/Internal", | ||
| "minimum_limit": 0, | ||
| "maximum_limit": 0, | ||
| "start_time": "0:00:00", | ||
| "end_time": "23:59:59", | ||
| "disabled": 1, | ||
| "priority": "1", | ||
|
There was a problem hiding this comment. This is account specific. Please bring in that key here. And do the following priority.
by default. Let the user re-order as per their need. |
||
| }, | ||
| ] | ||
|
|
||
| STD_BANK_LIST = [ | ||
| "Yes Bank", | ||
|
There was a problem hiding this comment. Remove Yes Bank as of now. Reorder this in alphabetical order. |
||
| "HDFC Bank", | ||
| "ICICI Bank", | ||
| "Axis Bank", | ||
| "Kotak Mahindra Bank", | ||
| ] | ||
|
|
||
| DEFAULT_WORKFLOW_STATE = [ | ||
| "Pending", | ||
| "Approved", | ||
| ] | ||
|
|
||
| DEFAULT_WORKFLOW_ACTIONS = ["Approve", "Reject"] | ||
|
|
||
| DEFAULT_WORKFLOW_LIST = [ | ||
| { | ||
| "doctype": "Workflow", | ||
| "document_type": "Bank Account", | ||
| "workflow_name": "Bank Account Approval", | ||
| "workflow_state_field": "workflow_state", | ||
| "is_active": 1, | ||
| "states": [ | ||
| { | ||
| "allow_edit": "All", | ||
| "doc_status": "0", | ||
| "parent": "Bank Account Approval", | ||
| "parentfield": "states", | ||
| "parenttype": "Workflow", | ||
| "state": "Pending", | ||
| "update_value": "Pending", | ||
| }, | ||
| { | ||
| "allow_edit": "Accounts Manager", | ||
| "doc_status": "0", | ||
| "parent": "Bank Account Approval", | ||
| "parentfield": "states", | ||
| "parenttype": "Workflow", | ||
| "state": "Approved", | ||
| "update_value": "Approved", | ||
| }, | ||
| ], | ||
| "transitions": [ | ||
| { | ||
| "state": "Pending", | ||
| "action": "Approve", | ||
| "next_state": "Approved", | ||
| "allowed": "Accounts Manager", | ||
| "allow_self_approval": 1, | ||
| "parent": "Bank Account Approval", | ||
| "parentfield": "transitions", | ||
| "parenttype": "Workflow", | ||
| }, | ||
| { | ||
| "action": "Reject", | ||
| "next_state": "Pending", | ||
| "allowed": "Accounts Manager", | ||
| "allow_self_approval": 1, | ||
| "parent": "Bank Account Approval", | ||
| "parentfield": "transitions", | ||
| "parenttype": "Workflow", | ||
| "state": "Approved", | ||
| }, | ||
| ], | ||
| } | ||
| ] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is every mode of transfer, by default disabled?