Refactor dev #13
Refactor dev #13
Conversation
refactor: update install file path
refactor: single payment code add in bank connector
fix: add filter to the bank account fix: fetch company bank account details during the API call
fix: rename method action in payload
refactor: add translate
refactor: pretify message content
fix: add missing fields
refactor: removed unused function 'get_bank_entry_for_payroll'
refactor: optimise payment request overrides code
…t entry and journal entry account
fix: add condition payment order type
india_banking/default.py
Outdated
| "maximum_limit": 200000, | ||
| "start_time": "0:00:00", | ||
| "end_time": "23:59:59", | ||
| "disabled": 1, |
There was a problem hiding this comment.
Why is every mode of transfer, by default disabled?
india_banking/default.py
Outdated
| { | ||
| "mode": "RTGS", | ||
| "minimum_limit": 200000, | ||
| "maximum_limit": 50000000, |
There was a problem hiding this comment.
Make 50 Crore as the upper limit, beyond that LEI number is required.
india_banking/default.py
Outdated
| { | ||
| "mode": "NEFT", | ||
| "minimum_limit": 0, | ||
| "maximum_limit": 100000000000, |
There was a problem hiding this comment.
Make 50 Crore as the upper limit, beyond that LEI number is required.
india_banking/default.py
Outdated
| "start_time": "0:00:00", | ||
| "end_time": "23:59:59", | ||
| "disabled": 1, | ||
| "priority": "1", |
There was a problem hiding this comment.
This is account specific. Please bring in that key here. And do the following priority.
- A2A
- IMPS
- RTGS
- NEFT
by default. Let the user re-order as per their need.
india_banking/default.py
Outdated
| ] | ||
|
|
||
| STD_BANK_LIST = [ | ||
| "Yes Bank", |
There was a problem hiding this comment.
Remove Yes Bank as of now. Reorder this in alphabetical order.
|
|
||
| after_install = ["india_banking.install.after_install"] | ||
|
|
||
| before_uninstall = "india_banking.uninstall.before_uninstall" |
There was a problem hiding this comment.
Can you put this in array too? Is it supported?
india_banking/hooks.py
Outdated
| doc_events = { | ||
| "Bank": {"on_trash": "india_banking.india_banking.doc_events.bank.bank_on_trash"}, | ||
| "Bank Account": { | ||
| "validate": "india_banking.india_banking.doc_events.bank.validate_ifsc_code" |
There was a problem hiding this comment.
Make a new file for bank_account, as it is a separate doctype.
india_banking/hooks.py
Outdated
| } | ||
|
|
||
| doc_events = { | ||
| "Bank": {"on_trash": "india_banking.india_banking.doc_events.bank.bank_on_trash"}, |
There was a problem hiding this comment.
Can we rename this function as disallow_standard_bank_deletion
| @@ -8,7 +8,8 @@ frappe.ui.form.on("Bank Connector", { | |||
| filters: { | |||
| disabled: 0, | |||
| is_default: 1, | |||
| is_company_account: 1 | |||
| is_company_account: 1, | |||
| company: doc.company, | |||
There was a problem hiding this comment.
Please use the standard linter and rectify the spacing for the entire repository.
|
|
||
|
|
||
| def validate_ifsc_code(doc, method=None): | ||
| if not IFSC_PATTERN.match(cstr(doc.branch_code)): |
There was a problem hiding this comment.
User often get confused with branch code and IFSC code. Can we set the label as IFSC Code for this field if this app is installed?
chore: rename 'bank_on_trash' to 'disallow_standard_bank_deletion' fix: update maximum limit for all mode of transfer chore: rename 'Branch Code' label to 'IFSC Code' in bank account doc
No description provided.