(feat) configuring containerPort from Values in datahub-frontend #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheerajrampally
changed the title
maggiehays
added
the
hacktoberfest-accepted
jjoyce0510
reviewed
Nov 7, 2023
| @@ -65,7 +65,7 @@ spec: | |||
| {{- toYaml .Values.lifecycle | nindent 12 }} | |||
| ports: | |||
| - name: http | |||
| containerPort: 9002 | |||
| containerPort: {{ .Values.service.containerPort }} | |||
There was a problem hiding this comment.
is it possible to specify a default inline here to 9002? I'm actually unsure :)
There was a problem hiding this comment.
the default is coming from the charts/datahub/subcharts/datahub-frontend/values.yaml file
darnaut
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
This change would make the containerPort configurable via values instead of directly hard-coding it.
Checklist