Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) configuring containerPort from Values in datahub-frontend #385

Merged
merged 7 commits into from
Nov 7, 2023
Merged

(feat) configuring containerPort from Values in datahub-frontend #385

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
07f43bc
configuring containerPort from Values in datahub-frontend
dheerajrampally Oct 20, 2023
877887d
bumping the chart version
dheerajrampally Oct 20, 2023
d2f5256
Update Chart.yaml
david-leifker Nov 7, 2023
1a15d34
Update Chart.yaml
david-leifker Nov 7, 2023
0a9d4f4
Merge branch 'master' into master
david-leifker Nov 7, 2023
d6a2582
Update Chart.yaml
david-leifker Nov 7, 2023
b52ed5f
Update Chart.yaml
david-leifker Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/datahub/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Helm chart for LinkedIn DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.3.3
version: 0.3.4
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.11.0
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-frontend/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ spec:
{{- toYaml .Values.lifecycle | nindent 12 }}
ports:
- name: http
containerPort: 9002
containerPort: {{ .Values.service.containerPort }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to specify a default inline here to 9002? I'm actually unsure :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default is coming from the charts/datahub/subcharts/datahub-frontend/values.yaml file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-11-07 at 9 11 38 AM

protocol: TCP
{{- if or .Values.global.datahub.monitoring.enablePrometheus .Values.global.datahub.monitoring.enableJMXPort }}
- name: jmx
Expand Down
1 change: 1 addition & 0 deletions charts/datahub/subcharts/datahub-frontend/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ service:
type: LoadBalancer # ClusterIP or NodePort
port: 9002
targetPort: http
containerPort: 9002
protocol: TCP
name: http
# Annotations to add to the service, this will help in adding
Expand Down
Loading