Address some minor issues in the ZRC2->ERC20 proxy, add tests and verification. #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(feat) Make zrc_proxy and decimals immutable (feat) Pass on the result of gas() and not 21000 (feat) Burnable ERC20s (feat) Tests for ERC20 proxy contract. (feat) Deployment for ERC20 proxy is now via task and auto-verifies the contract
… complained at me for this, but it now seems fine! (fix) Don't limit deployment gas.
… authors may want to use.
lukozill
requested changes
Aug 30, 2024
contracts/experimental/ERC20ProxyForZRC2/contracts/ScillaConnector.sol
Outdated
Show resolved
Hide resolved
contracts/experimental/ERC20ProxyForZRC2/test/basicProxyTest.ts
Outdated
Show resolved
Hide resolved
contracts/experimental/ERC20ProxyForZRC2/test/basicProxyTest.ts
Outdated
Show resolved
Hide resolved
contracts/experimental/ERC20ProxyForZRC2/test/basicProxyTest.ts
Outdated
Show resolved
Hide resolved
contracts/experimental/ERC20ProxyForZRC2/test/basicProxyTest.ts
Outdated
Show resolved
Hide resolved
contracts/experimental/ERC20ProxyForZRC2/test/basicProxyTest.ts
Outdated
Show resolved
Hide resolved
…ctor.sol Co-authored-by: Lukasz Kosiak <[email protected]>
Co-authored-by: Lukasz Kosiak <[email protected]>
Co-authored-by: Lukasz Kosiak <[email protected]>
Co-authored-by: Lukasz Kosiak <[email protected]>
lukozill
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(feat) Documentation
(feat) Make zrc_proxy and decimals immutable
(feat) Pass on the result of gas() and not 21000
(feat) Burnable ERC20s
(feat) Tests for ERC20 proxy contract.
(feat) Deployment for ERC20 proxy is now via task and auto-verifies the contract
Closses #721