Address ERC2 wrapper improvements #727
Conversation
(feat) Make zrc_proxy and decimals immutable (feat) Pass on the result of gas() and not 21000 (feat) Burnable ERC20s
| * @param tran_name The name of the function to call | ||
| * @param arg1 The first argument to the function | ||
| */ | ||
| function callu128( |
There was a problem hiding this comment.
FWIW Solidity allows function overloading based on parameter types, so we could still name this call?
There was a problem hiding this comment.
We could, but when I try it, it fails to resolve .. I'll try again, but :-(
There was a problem hiding this comment.
Hmph. It works now - sorry & thanks for the spot! Will update - confusingly, the other PR .. sorry!
| // ZRC2 addresses frequently have bad checksums, hence toLowerCase(). | ||
| const contract = await ethers.deployContract("ZRC2ERC20Proxy", | ||
| [zrc2Address.toLowerCase()], | ||
| { gasLimit: 1_000_000 }); |
There was a problem hiding this comment.
Is setting the gasLimit necessary? (i.e. does estimate gas fail/lie for these transactions?)
Setting a fixed limit means this can break if gas charges change in the future.
There was a problem hiding this comment.
Well caught - sorry again - inherited from previous script for no reason I could see. Will fix in other PR ..
|
Closing this PR in favour of #729 . which no longer has the abortive attempt to switch to foundry. |
Draft PR for ERC2 wrapper improvements.