Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add flex gap to overflow list calculations #3021

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

NicholasBoll
Copy link
Member

Summary

Adds Flexbox gap to overflow list calculations so that a the overflow list doesn't render outside the container. This is more noticeable with higher gap values.

Fixes #3020

Release Category

Components


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)

Where Should the Reviewer Start?

Spec file. Also look at the overflow tabs example and choose 500px

Areas for Feedback? (optional)

  • Code
  • Testing

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

Adds Flexbox `gap` to overflow list calculations so that a the overflow list doesn't render outside the container. This is more noticeable with higher gap values.

Fixes #3020
@github-actions github-actions bot added the ready for review Code is ready for review label Nov 1, 2024
@alanbsmith alanbsmith merged commit 4cb831f into support Nov 4, 2024
24 checks passed
@alanbsmith alanbsmith deleted the fix/add-gap-in-overflow-list-calculations branch November 4, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge ready for review Code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Overflow measure in the collection system to account for gap.
3 participants