Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Overflow measure in the collection system to account for gap. #3020

Closed
mannycarrera4 opened this issue Nov 1, 2024 · 0 comments · Fixed by #3021
Closed

Update Overflow measure in the collection system to account for gap. #3020

mannycarrera4 opened this issue Nov 1, 2024 · 0 comments · Fixed by #3021
Labels
11.x bug Something isn't working

Comments

@mannycarrera4
Copy link
Contributor

🐛 Bug Report

Our overflow detection wasn't accurately accounting for list items that were within a flex container that spaced the items out with the css gap property. We should update our calculations to account for this. These change should go into our collection system. This might cause some small snap shot tests to be off by a few pixels.
@mannycarrera4 mannycarrera4 added bug Something isn't working 11.x labels Nov 1, 2024
@jaclynjessup jaclynjessup moved this to 🆕 New in Canvas Kit Nov 1, 2024
NicholasBoll added a commit that referenced this issue Nov 1, 2024
@NicholasBoll
fix: Add flex gap to overflow list calculations
2473b07 
Adds Flexbox `gap` to overflow list calculations so that a the overflow list doesn't render outside the container. This is more noticeable with higher gap values.

Fixes #3020
@NicholasBoll NicholasBoll mentioned this issue Nov 1, 2024
Merged
6 tasks
@NicholasBoll NicholasBoll linked a pull request Nov 1, 2024 that will close this issue
fix: Add flex gap to overflow list calculations #3021
Merged
6 tasks
alanbsmith pushed a commit that referenced this issue Nov 4, 2024
@NicholasBoll
fix: Add flex gap to overflow list calculations (#3021)
4cb831f 
Adds Flexbox `gap` to overflow list calculations so that a the overflow list doesn't render outside the container. This is more noticeable with higher gap values.

Fixes #3020

[category:Components]
@github-actions github-actions bot closed this as completed Nov 4, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Canvas Kit Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
11.x bug Something isn't working
Projects
Canvas Kit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add flex gap to overflow list calculations Workday/canvas-kit
1 participant
@mannycarrera4