Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chevron icon for local nav mobile menu #254

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Oct 17, 2023

Changes the local navigation blocks to use the 'menu' (3 bar) icon on mobile, so that in conjunction with WordPress/wporg-mu-plugins#480 the button changes from the word 'Menu' to a chevron icon.

Screenshots

State Home Single Thanks
Closed localhost_8888_(Samsung Galaxy S20 Ultra) (12) localhost_8888_meta-newsroom_(Samsung Galaxy S20 Ultra) localhost_8888_submit-a-wordpress-site_thanks_(Samsung Galaxy S20 Ultra) (5)
Open localhost_8888_(Samsung Galaxy S20 Ultra) (13) localhost_8888_meta-newsroom_(Samsung Galaxy S20 Ultra) (1) localhost_8888_submit-a-wordpress-site_thanks_(Samsung Galaxy S20 Ultra) (6)

Testing

  1. Ensure your mu-plugins is on Add filter to replace local nav bar mobile menu icon wporg-mu-plugins#480
  2. There are 3 different navs, so you need to test Home, Single, and Thanks pages
  3. Simulate mobile size and check the menu icons when open and closed, a caret should be displayed for both

@adamwoodnz adamwoodnz self-assigned this Oct 17, 2023
@adamwoodnz adamwoodnz added this to the Future milestone Oct 17, 2023
@adamwoodnz adamwoodnz added [Component] Theme Templates, patterns, CSS [Type] Enhancement New feature or request labels Oct 17, 2023
@adamwoodnz adamwoodnz changed the title Use menu icon for local nav Use chevron icon for local nav mobile menu Oct 18, 2023
@adamwoodnz adamwoodnz requested review from StevenDufresne, renintw and a team October 18, 2023 04:43
@jasmussen
Copy link

Looks good but the chevron needs to line up, currently it's offset to the right:

not-aligned

It should be more like this:

aligned

Nice work.

@adamwoodnz
Copy link
Contributor Author

Looks good but the chevron needs to line up

Ah I forgot to update the screenshots after we updated it in mu-plugins

They're centrally aligned now, as you saw in the other repos 👍

@adamwoodnz adamwoodnz merged commit e0127c7 into main Oct 18, 2023
1 check passed
@adamwoodnz adamwoodnz deleted the update/463-local-nav-menu-icon branch October 18, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS [Type] Enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants