Add filter to replace local nav bar mobile menu icon #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
force-pushed
the
update/463-local-nav-menu-icon
branch
from
0edbac8 to
db61241
Compare
adamwoodnz
requested review from
ndiego,
renintw,
StevenDufresne,
marko-srb and
fcoveram
|
I tried testing this with main@trunk and showcase@trunk. I wasn't able to get it to work. The function was called but failed on the nested ifs. Do I have to do something to those themes to get it to work? |
Yep, the nav blocks need a new setting |
This was referenced Oct 18, 2023
|
Can we get this either right aligned or centered aligned with the hamburger menu? Center aligned would probably feel better. 
|
Yep! Try now. |
|
LGTM. Should this be rolled out for the whole site at once? |
|
It's very cool that this is using the HTML API from a developer relations perspective. A great, real-world example for folks to see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #463
Implementation taken from @ndiego's comment, with a couple of minor changes. The outer block is the
wporg/local-navigation-barwhich wraps a navigation block.Requires a navigation to have the 3 bar menu icon set (
"icon":"menu"), so that the SVG path can be changed to use a caret instead. All the repos where the local nav bar is used will need to have this updated, as they currently have"hasIcon": falseand use the word 'Menu' (Developer, Documentation, Showcase, Main).Screenshots
Testing
Easiest to try it out on WordPress/wporg-showcase-2022#254