Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event list location position #1175

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

renintw
Copy link
Contributor

@renintw renintw commented Dec 11, 2023

Fixes #1151 (comment)

In design, for a 1280px screen size, the width left part (event title section) of an event item is 470px. The total width of the event item is 1080px. 470/1080~=43%. So I set the ratio to 45% for screen sizes smaller than --wide (1280px).
For those larger than 1280px, I've configured it to be 60% (950/1560).

Screencast

aa.mov

@renintw renintw self-assigned this Dec 11, 2023
@renintw renintw added this to the Events: Promotion milestone Dec 11, 2023
Base automatically changed from enhance/clean-up-stylesheet to production December 12, 2023 17:54
@renintw renintw force-pushed the fix/event-list-location-position branch from ea5058c to f37377d Compare December 12, 2023 17:57
@renintw renintw force-pushed the fix/event-list-location-position branch from f37377d to 14e20bb Compare December 12, 2023 18:01
@renintw renintw merged commit 6025aee into production Dec 12, 2023
3 checks passed
@renintw renintw deleted the fix/event-list-location-position branch December 12, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant