Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events: Breakpoint change for a cleaner cover #1151

Merged

Conversation

renintw
Copy link
Contributor

@renintw renintw commented Dec 7, 2023

Fixes #1138

Screencast

Keep the mobile's vertical distribution of cover area (Heading, sub text, and map) until it reaches 960px

temp.cover.resize.mp4

Between 600-900, place location, date, and time labels horizontally in a single line.

fff.mp4

@renintw renintw marked this pull request as draft December 7, 2023 21:50
@renintw renintw changed the title Keep the Mobile's vertical distribution of cover area until 960px. Events: Breakpoint change for a cleaner cover Dec 7, 2023
@renintw renintw force-pushed the enhance/Breakpoint-change-for-a-cleaner-cover branch from dd74330 to ac425be Compare December 11, 2023 04:49
@renintw renintw self-assigned this Dec 11, 2023
@renintw renintw marked this pull request as ready for review December 11, 2023 05:35
@renintw renintw requested a review from adamwoodnz December 11, 2023 05:35
@renintw renintw added this to the Events: Promotion milestone Dec 11, 2023
@StevenDufresne
Copy link
Contributor

This looks better.

I don't think we need to stack the dates anymore since the font-size was brought down to 14px until large screens.

@renintw
Copy link
Contributor Author

renintw commented Dec 11, 2023

You mean this one, right?
image

If not stacking, for some screen size, it would look like this (this is under screen size wider than large, 960px)
image

Saw this as well on screen size 963px
image

And found that the font size changes to 14px until xlarge 1080px, instead of large 960px. Just noted. It doesn't change anything if switching font size earlier when it reaches 960px.

@StevenDufresne
Copy link
Contributor

I see, there are cases where it breaks and looks bad.

I'm starting to think we could do this instead:

Screenshot 2023-12-11 at 3 06 29 PM

@renintw
Copy link
Contributor Author

renintw commented Dec 11, 2023

I've pushed a new change, it should match our expectations now.

I made the Date block size bigger, 1.5fr. I guess this would fit the longest format of the date. (Saturday, April 30?)

@renintw renintw force-pushed the enhance/Breakpoint-change-for-a-cleaner-cover branch from 9952ea2 to a0351ce Compare December 11, 2023 06:15
@StevenDufresne
Copy link
Contributor

Doesn't work in all cases.

Screenshot 2023-12-11 at 3 17 25 PM

@renintw
Copy link
Contributor Author

renintw commented Dec 11, 2023

OK, I've changed it from 1.5fr to 2fr. It works for
image

I think this is the longest one? Although I think for April it would be Apr? This form isn't broken under all screen sizes.

Also tried Wednesday, March 31

asdfds.mp4

Copy link
Contributor

@StevenDufresne StevenDufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's go with this. We can adjust later.

@StevenDufresne StevenDufresne merged commit 0f004b8 into production Dec 11, 2023
3 checks passed
@StevenDufresne StevenDufresne deleted the enhance/Breakpoint-change-for-a-cleaner-cover branch December 11, 2023 06:44
@StevenDufresne
Copy link
Contributor

Something I missed: On wide screens the location should be closer to the date.

Production Designs
Screenshot 2023-12-11 at 5 17 18 PM Screenshot 2023-12-11 at 5 18 17 PM

@renintw
Copy link
Contributor Author

renintw commented Dec 11, 2023

Something I missed: On wide screens the location should be closer to the date.

Fixed in #1175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Events: Breakpoint change for a cleaner cover
2 participants