Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check restricted plugin header fields #670

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

ernilambar
Copy link
Member

Fixes #669

@ernilambar ernilambar force-pushed the 669-restrict-custom-plugin-headers branch from e7dc957 to 4ccecc6 Compare September 26, 2024 10:51
@ernilambar ernilambar marked this pull request as ready for review September 26, 2024 10:51
Copy link

github-actions bot commented Sep 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar
Copy link
Member Author

@swissspidy Since we are now using get_file_data() for fetching headers, we could also validate Network field which we postponed earlier. I will do it in follow up PR.

@davidperezgar
Copy link
Member

davidperezgar commented Sep 26, 2024

Thanks Nilambar for being fast to solve this meta's request.

@ernilambar ernilambar added this to the 1.2.0 milestone Sep 26, 2024
@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Sep 26, 2024
@ernilambar ernilambar merged commit 64cf979 into trunk Sep 26, 2024
34 checks passed
@ernilambar ernilambar deleted the 669-restrict-custom-plugin-headers branch September 26, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict custom plugin headers
3 participants