Restricted Headers: remove ones that are allowed, but leave the mech for checking in place for future use #720
Conversation
…for checking in place for future use
kraftbj
requested review from
barrykooij,
ernilambar,
davidperezgar and
frantorres
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @octalmage. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thank you Brandon. |
There was a problem hiding this comment.
This makes a lot of sense and keeps the functionality available for problematic comments that could be moved in here like the one which lets you override the Update URI (https://make.wordpress.org/core/2021/06/29/introducing-update-uri-plugin-header-in-wordpress-5-8/)
|
I approve this! ☝️ |
|
Thank you! |
|
I've chatted with @chriscct7 and I agree with reverting this change for now, assigning it to him to handle. |
chriscct7
requested review from
chriscct7
and removed request for
barrykooij,
ernilambar,
davidperezgar and
frantorres
chriscct7
added
Checks
|
Thank you! |
Partly reverts the functionality of #670.
Resolves #718
Per the conversation in #669, the presence of these headers—in and of themselves—do not create a third-party upgrader situation. The UpdateURI, which is already checked elsewhere, does prevent the updates from WordPress.org, but the headers originally included in this code are for information only.