Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in the plugin #246

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Fix typos in the plugin #246

merged 2 commits into from
Aug 29, 2023

Conversation

mukeshpanchal27
Copy link
Member

Closes #245

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.

@mukeshpanchal27
Copy link
Member Author

PHPCS shows - The package "wp-coding-standards/wpcs" is pointing to a commit-ref, this is bad practice and can cause unforeseen issues. error because we use unstable version.

@swissspidy I follow same steps that we did for #163 (comment) but still it not working in local could you guide me why it not working when i run composer update or composer install

@swissspidy
Copy link
Member

@mukeshpanchal27 That's just a warning, not an error. The actual error is that the lock file is now out of date because of the fixed typo in composer.json

# Lock file errors
- The lock file is not up to date with the latest changes in composer.json, it is recommended that you run `composer update` or `composer update <package name>`.
# General warnings
- The package "wp-coding-standards/wpcs" is pointing to a commit-ref, this is bad practice and can cause unforeseen issues.
- require.automattic/vipwpcs : exact version constraints (2.3.3) should be avoided if the package follows semantic versioning

Just running composer update fixes this.

@mukeshpanchal27
Copy link
Member Author

Thanks @swissspidy for the quick reply.

If we check same for trunk then also we get same error 🤔, I have tried composer update and composer install but it show same error for me.

Screenshot 2023-08-16 at 2 12 56 PM

@swissspidy
Copy link
Member

Still just warnings, not errors. They can be safely ignored.

@swissspidy
Copy link
Member

Let‘s merge trunk, resolve conflicts and run composer update. Then this one is good to go

@mukeshpanchal27
Copy link
Member Author

Thanks @swissspidy, The PR is ready for review. cc. @joemcgill @felixarntz

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixarntz felixarntz merged commit c0d5a0c into trunk Aug 29, 2023
12 checks passed
@felixarntz felixarntz deleted the fix/245-typos branch August 29, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typos in the plugin
3 participants