-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in the plugin #246
Conversation
PHPCS shows - @swissspidy I follow same steps that we did for #163 (comment) but still it not working in local could you guide me why it not working when i run |
@mukeshpanchal27 That's just a warning, not an error. The actual error is that the lock file is now out of date because of the fixed typo in
Just running |
Thanks @swissspidy for the quick reply. If we check same for trunk then also we get same error 🤔, I have tried |
Still just warnings, not errors. They can be safely ignored. |
Let‘s merge trunk, resolve conflicts and run composer update. Then this one is good to go |
Thanks @swissspidy, The PR is ready for review. cc. @joemcgill @felixarntz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mukeshpanchal27!
Closes #245
Checklist: