Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error shows by composer validate #248

Closed
1 task done
mukeshpanchal27 opened this issue Aug 16, 2023 · 0 comments · Fixed by #252
Closed
1 task done

Fix error shows by composer validate #248

mukeshpanchal27 opened this issue Aug 16, 2023 · 0 comments · Fixed by #252
Labels
[Type] Bug An existing feature is broken

Comments

@mukeshpanchal27
Copy link
Member

Describe the bug

I discovered this bug, and then I worked on the #246 (comment). I also managed to reproduce the same issue in the trunk.

Error:

- The package "wp-coding-standards/wpcs" is pointing to a commit-ref, this is bad practice and can cause unforeseen issues.
- require.automattic/vipwpcs : exact version constraints (2.3.3) should be avoided if the package follows semantic versioning

Steps to Reproduce

  1. Clone the repo code in your local system
  2. Install composer
  3. Run composer validate
  4. Check errors

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mukeshpanchal27 mukeshpanchal27 added the [Type] Bug An existing feature is broken label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant