Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard template and currency format in Helper class #44

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update dashboard template and currency format in Helper class #44

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a20c10c
chore: update dashboard template
Jun 18, 2024
9e0df48
refactor: update currency format in Helper class
Jun 19, 2024
ae87a16
refactor: update currency format in Helper class
Jun 26, 2024
50c44bf
refactor: update currency format in Helper class
Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Helpers/Helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class Helper
{
public static function convertToRupiah($price)
{
return 'Rp. '.number_format($price, 2, ',', '.');
return '$. '.number_format($price, 2, ',', '.');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it's convertToRupiah, it should've been prefixed with Rp. (Rupiah), we can add one more static method for creating dollar convertor if you want, and im open for it.

If we want to support more than 1 convertor, we can find package that has already create it.

}

public static function thisMonth()
Expand Down
20 changes: 10 additions & 10 deletions database/factories/RoomFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,16 @@ public function definition()
'D',
];
$price = [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep this change on cloned repo only i think? since overall of this app built with rupiah

450000,
500000,
650000,
700000,
850000,
950000,
1200000,
1500000,
1750000,
2000000,
450,
500,
650,
700,
850,
950,
1200,
1500,
1750,
2000,
];
static $order = 10;

Expand Down
1 change: 1 addition & 0 deletions public/hot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
http://[::1]:5173
Copy link
Owner

@WailanTirajoh WailanTirajoh Jun 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can ignore this file on .gitignore i guess, feel free to add that there.

1 change: 1 addition & 0 deletions resources/views/dashboard/index.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
@extends('template.master')
@section('title', 'Dashboard')

@section('content')
<div id="dashboard">
<div class="row">
Expand Down