Update dashboard template and currency format in Helper class #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ class Helper | |||
| { | |||
| public static function convertToRupiah($price) | |||
| { | |||
| return 'Rp. '.number_format($price, 2, ',', '.'); | |||
| return '$. '.number_format($price, 2, ',', '.'); | |||
There was a problem hiding this comment.
since it's convertToRupiah, it should've been prefixed with Rp. (Rupiah), we can add one more static method for creating dollar convertor if you want, and im open for it.
If we want to support more than 1 convertor, we can find package that has already create it.
| @@ -29,16 +29,16 @@ public function definition() | |||
| 'D', | |||
| ]; | |||
| $price = [ | |||
There was a problem hiding this comment.
let's keep this change on cloned repo only i think? since overall of this app built with rupiah
| @@ -0,0 +1 @@ | |||
| http://[::1]:5173 | |||
There was a problem hiding this comment.
we can ignore this file on .gitignore i guess, feel free to add that there.
|
Anyway thankyou for the PR! feel free to discus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.