Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Manage Students): Remove student does not update the UI #1450

Merged
merged 3 commits into from
Oct 13, 2023
Merged

fix(Manage Students): Remove student does not update the UI #1450

merged 3 commits into from
Oct 13, 2023

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Oct 4, 2023 •
edited
Loading

Changes

  • Remove student now removes the student from the UI. The UI used to not change at all after removing a student.
  • If the student is in multiple workgroups, it only removes them from the workgroup you clicked on. If we want to remove them from all workgroups, we could send a message to all workgroups. Theoretically this would not be needed if students can no longer be in multiple workgroups.

Test

Closes #1449

@geoffreykwan geoffreykwan self-assigned this Oct 4, 2023
@geoffreykwan geoffreykwan mentioned this pull request Oct 4, 2023
Merged
@geoffreykwan geoffreykwan marked this pull request as ready for review October 4, 2023 20:39
hirokiterashima
hirokiterashima approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffreykwan geoffreykwan merged commit 06336ba into develop Oct 13, 2023
2 checks passed
@geoffreykwan geoffreykwan deleted the issue-1449-remove-student-does-not-update-ui branch October 13, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
None yet
Projects
WISE Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(Manage Students): Remove student does not update the UI
2 participants
@geoffreykwan @hirokiterashima