Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Manage Students): Remove student does not remove from all workgroups #243

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Oct 4, 2023

Changes

Remove student now removes the student from all the workgroups in the run instead of just one workgroup.

Test

Closes #242

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffreykwan geoffreykwan merged commit 61a01ac into develop Oct 13, 2023
@geoffreykwan geoffreykwan deleted the issue-242-remove-student-does-not-remove-from-all-workgroups branch October 13, 2023 15:36
@geoffreykwan
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

breity pushed a commit to I-Sparkle-Germany/I-Sparkle-API that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug(Manage Students): Remove student does not remove from all workgroups
2 participants