refactor(NodeService): remove dialog parameter from constructors in N…

…odeService and TeacherNodeService. It's only used in StudentNodeService.
WISE-Community · Dec 20, 2024 · b43059e · b43059e
1 parent 9c57795
commit b43059e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/src/assets/wise5/services/nodeService.ts b/src/assets/wise5/services/nodeService.ts
@@ -1,5 +1,4 @@
 import { Injectable } from '@angular/core';
-import { MatDialog } from '@angular/material/dialog';
 import { ConfigService } from './configService';
 import { ProjectService } from './projectService';
 import { DataService } from '../../../app/services/data.service';
@@ -17,7 +16,6 @@ export abstract class NodeService {
     protected configService: ConfigService,
     protected constraintService: ConstraintService,
     protected dataService: DataService,
-    protected dialog: MatDialog,
     protected projectService: ProjectService
   ) {}
 

diff --git a/src/assets/wise5/services/studentNodeService.ts b/src/assets/wise5/services/studentNodeService.ts
@@ -20,11 +20,11 @@ export class StudentNodeService extends NodeService {
     protected configService: ConfigService,
     protected constraintService: ConstraintService,
     protected dataService: StudentDataService,
-    protected dialog: MatDialog,
+    private dialog: MatDialog,
     private nodeStatusService: NodeStatusService,
     protected projectService: ProjectService
   ) {
-    super(configService, constraintService, dataService, dialog, projectService);
+    super(configService, constraintService, dataService, projectService);
   }
 
   setCurrentNode(nodeId: string): void {

diff --git a/src/assets/wise5/services/teacherNodeService.ts b/src/assets/wise5/services/teacherNodeService.ts
@@ -3,7 +3,6 @@ import { NodeService } from './nodeService';
 import { Subject, Observable } from 'rxjs';
 import { TeacherDataService } from './teacherDataService';
 import { TeacherProjectService } from './teacherProjectService';
-import { MatDialog } from '@angular/material/dialog';
 import { ConfigService } from './configService';
 import { ConstraintService } from './constraintService';
 
@@ -21,10 +20,9 @@ export class TeacherNodeService extends NodeService {
     protected configService: ConfigService,
     protected constraintService: ConstraintService,
     protected dataService: TeacherDataService,
-    protected dialog: MatDialog,
     protected projectService: TeacherProjectService
   ) {
-    super(configService, constraintService, dataService, dialog, projectService);
+    super(configService, constraintService, dataService, projectService);
   }
 
   broadcastComponentShowSubmitButtonValueChanged(args: any): void {