refactor(NodeService): reorder constructor parameters alphabetically …

…for consistency across services
WISE-Community · Dec 20, 2024 · 9c57795 · 9c57795
1 parent dc01597
commit 9c57795
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/src/assets/wise5/services/nodeService.ts b/src/assets/wise5/services/nodeService.ts
@@ -8,16 +8,16 @@ import { ConstraintService } from './constraintService';
 
 @Injectable()
 export abstract class NodeService {
-  private nodeSubmitClickedSource: Subject<any> = new Subject<any>();
-  public nodeSubmitClicked$: Observable<any> = this.nodeSubmitClickedSource.asObservable();
   private doneRenderingComponentSource: Subject<any> = new Subject<any>();
   public doneRenderingComponent$ = this.doneRenderingComponentSource.asObservable();
+  private nodeSubmitClickedSource: Subject<any> = new Subject<any>();
+  public nodeSubmitClicked$: Observable<any> = this.nodeSubmitClickedSource.asObservable();
 
   constructor(
-    protected dataService: DataService,
-    protected dialog: MatDialog,
     protected configService: ConfigService,
     protected constraintService: ConstraintService,
+    protected dataService: DataService,
+    protected dialog: MatDialog,
     protected projectService: ProjectService
   ) {}
 

diff --git a/src/assets/wise5/services/studentNodeService.ts b/src/assets/wise5/services/studentNodeService.ts
@@ -17,14 +17,14 @@ export class StudentNodeService extends NodeService {
   private transitionResults = {};
 
   constructor(
-    protected dataService: StudentDataService,
-    protected dialog: MatDialog,
     protected configService: ConfigService,
     protected constraintService: ConstraintService,
+    protected dataService: StudentDataService,
+    protected dialog: MatDialog,
     private nodeStatusService: NodeStatusService,
     protected projectService: ProjectService
   ) {
-    super(dataService, dialog, configService, constraintService, projectService);
+    super(configService, constraintService, dataService, dialog, projectService);
   }
 
   setCurrentNode(nodeId: string): void {

diff --git a/src/assets/wise5/services/teacherNodeService.ts b/src/assets/wise5/services/teacherNodeService.ts
@@ -18,13 +18,13 @@ export class TeacherNodeService extends NodeService {
   public starterStateResponse$: Observable<any> = this.starterStateResponseSource.asObservable();
 
   constructor(
-    protected dataService: TeacherDataService,
-    protected dialog: MatDialog,
     protected configService: ConfigService,
     protected constraintService: ConstraintService,
+    protected dataService: TeacherDataService,
+    protected dialog: MatDialog,
     protected projectService: TeacherProjectService
   ) {
-    super(dataService, dialog, configService, constraintService, projectService);
+    super(configService, constraintService, dataService, dialog, projectService);
   }
 
   broadcastComponentShowSubmitButtonValueChanged(args: any): void {