Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block tag for unethical TNT check #4769

Merged

Conversation

TheRealWormbo
Copy link
Collaborator

Resolves #4768 (AE2 Tiny TNT duping test) but in a better way.

@Suisuroru
Copy link

Suisuroru commented Nov 28, 2024

It works well, but I think a config is a better choice for server operators, if they find a tnt can't be reconized as TntBlock in server operating ,they can fix it themselves, and this also provides a more open space for adjustment in their personal way.
I also suggest that it is needed a interface to change the botania:rfgenerator 's mana conversion efficiency. In fact, the rate 1:10 is not well for every Industry mod.Like mek ,there is too low efficiency to generate energy , it make use mana to generate FE is no meaning for normal player in game.

@TheRealWormbo
Copy link
Collaborator Author

Being a block tag means it is by definition configurable. You need to make a data pack, which you probably have anyway if you plug mods together manually.

@TheRealWormbo TheRealWormbo merged commit 3a372a7 into VazkiiMods:1.20.x Nov 29, 2024
1 check passed
@TheRealWormbo TheRealWormbo deleted the 1.20-unethical-tnt-block-tag branch November 29, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants