Custom TNT ethical fix #4768
Closed
Custom TNT ethical fix #4768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suisuroru
changed the title
|
I think I'd prefer a solution that doesn't use string matching, because this needs to test every single block that is being moved and thus is somewhat performance-critical. Maybe something like testing the moved state for a block tag? Which block exactly gets around the check? |
|
In AE2, the custom tnt is appliedenergistics2:tiny_tnt.
Tiny tnt can pass Entropinnyum's monitor and generate mana, but it can't be tracked in ethnic tnt judgement.So it will generate 6500 mana instead of 3 mana.
|
|
this bug may caused by the custom tnt like tiny tnt (from AE2) can't be recognized as TntBlock.
Caused by(maybe):
movingBlockEntity.getMovedState().getBlock() instanceof TntBlock) {Xplat/src/main/java/vazkii/botania/common/helper/EthicalTntHelper.java 121:
|
TheRealWormbo
added a commit
to TheRealWormbo/Botania
that referenced
this pull request
Nov 28, 2024
|
Can you please look at #4769 to check if that implementation would fix the issue? |
|
PR#4768 works well, but I think a config is a better choice for server operators, if they find a tnt can't be reconized as TntBlock in server operating ,their can fix it themselves, and this also provides a more open space for adjustment in their personal way.
I also suggest that it is needed a interface to change the botania:rfgenerator 's mana conversion efficiency. Infact the rate 1:10 is not well for every Industry mod.Like mek ,there is too low efficiency to generate energy , it make use mana to generate FE is no meaning for normal player in game.
…------------------ Original ------------------
From: "VazkiiMods/Botania" ***@***.***>;
Date: Thu, Nov 28, 2024 04:14 PM
***@***.***>;
***@***.******@***.***>;
Subject: Re: [VazkiiMods/Botania] Custom TNT ethical fix (PR #4768)
Can you please look at #4769 to check if that implementation would fix the issue?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I think it is solved in #4769 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug will not happen on vanilla server, it will happened with some mod like AE2, their custom tnt can provide the ethical logic misjudgment. I have modified the logic for determining whether TNT is ethical to recognize other entities with TNT fields. I have checked the situation where the vanilla item does not have TNT, and those that have been judged as ethical have already been judged as TNT, so there should be no misjudgment