-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialisation aliases #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penelopeysm
force-pushed
the
serialisation-aliases
branch
from
July 1, 2024 08:57
904b5c0
to
99efd3d
Compare
The tests don't currently pass. However, they should (hopefully!) pass if you do either one of these:
|
sgreenbury
reviewed
Jul 3, 2024
sgreenbury
reviewed
Jul 3, 2024
sgreenbury
reviewed
Jul 3, 2024
Thanks for this @penelopeysm, looks great! I've just updated the config b131f59 to point to a path with the new data (will open an issue to point to modify to point to same path as the final released data) and added a few small comments/queries above in the code. |
Co-authored-by: Sam Greenbury <[email protected]>
Merging this now, thanks @penelopeysm! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to https://github.com/Urban-Analytics-Technology-Platform/popgetter/pull/130.
Merge that first and regenerate all the BE/NI data before testing this PR! The CI is failing now because the proposed changes do not match our current data.
This PR:
It would be cool if we had a test to get the column names from upstream Python and check that they are equal to the ones here. I haven't done that, though. Alternatively, if we one day merge the two repos into one, they could potentially be derived from the same file.