Add caching for CLI #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgreenbury
force-pushed
the
74-caching
branch
from
4815041 to
5a06dca
Compare
sgreenbury
commented
Sep 3, 2024
| @@ -144,6 +144,32 @@ impl From<OutputFormat> for OutputFormatter { | |||
| } | |||
| } | |||
|
|
|||
| async fn read_popgetter(config: Config) -> anyhow::Result<Popgetter> { | |||
There was a problem hiding this comment.
Consider moving this implementation to be part of the popgetter crate as part of #46 if the same caching approach can be used.
sgreenbury
commented
Sep 3, 2024
sgreenbury
commented
Sep 3, 2024
sgreenbury
commented
Sep 3, 2024
| } | ||
| use paths as PATHS; |
There was a problem hiding this comment.
Refactored as module since no methods expected (see #56 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74