Merge pull request #493 from Unity-Technologies/UT-3149-remove-export…

…-geometry-option Ut 3149 remove export geometry option
Unity-Technologies · Jan 13, 2020 · 4ec8bad · 4ec8bad
2 parents 3f3d6de + c0922ca
commit 4ec8bad
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 26 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,15 +1,18 @@
 # Changes in Fbx Exporter
 
-## [3.0.0-preview.1] - 2020-01-08
+## [3.0.0-preview.1] - 2020-01-13
 ### Added
-- Added FBX Recorder to record animations from the Unity Recorder directly to FBX (adds dependency to Unity Recorder)
-- Export animated focal length and lens shift of cameras
+- Added FBX Recorder to record animations from the Unity Recorder directly to FBX (adds dependency to Unity Recorder).
+- Export animated focal length and lens shift of cameras.
 
 ### Changed
-- Updated dependency to com.autodesk.fbx version 3.0.0-preview.1, which means we update to [FBX SDK 2020](http://help.autodesk.com/view/FBX/2020/ENU/)
+- Updated dependency to com.autodesk.fbx version 3.0.0-preview.1, which means we update to [FBX SDK 2020](http://help.autodesk.com/view/FBX/2020/ENU/).
 
 ### Fixed
-- Fixed camera aspect and gate fit exporting as incorrect values
+- Fixed camera aspect and gate fit exporting as incorrect values.
+
+### Known Issues
+- Using the FBX Recorder to record animated characters is not supported yet, and fails in some cases.
 
 ## [2.0.3-preview.3] - 2019-09-24
 

diff --git a/com.unity.formats.fbx/Documentation~/images/FBXExporter_RecorderSettings.png b/com.unity.formats.fbx/Documentation~/images/FBXExporter_RecorderSettings.png
diff --git a/com.unity.formats.fbx/Documentation~/recorder.md b/com.unity.formats.fbx/Documentation~/recorder.md
@@ -18,7 +18,6 @@ Alternatively, the FBX Recorder can be added as a track in the Timeline.
 
 | Property:                     | Function:                                                    |
 | :---------------------------- | :----------------------------------------------------------- |
-| __Export Geometry__              | Check this option to export the geometry of the recorded GameObject to FBX, if any. |
 | __File Name__            | The filename for the exported FBX. |
 | __Path__                 | The path to export the FBX to. Can be outside of the Assets folder. |
 | __Take Number__          | The take number can be set and used in the filename. It automatically increments after each recording. |

diff --git a/com.unity.formats.fbx/Editor/Sources/Recorders/FbxRecorder/FbxRecorder.cs b/com.unity.formats.fbx/Editor/Sources/Recorders/FbxRecorder/FbxRecorder.cs
@@ -63,10 +63,6 @@ protected override void EndRecording(RecordingSession session)
                 AnimationUtility.SetAnimationClips(animator, new AnimationClip[] { clip });
                 var exportSettings = new ExportModelSettingsSerialize();
                 var toInclude = ExportSettings.Include.ModelAndAnim;
-                if (!settings.ExportGeometry)
-                {
-                    toInclude = ExportSettings.Include.Anim;
-                } 
                 exportSettings.SetModelAnimIncludeOption(toInclude);
                 ModelExporter.ExportObject(clipName, root, exportSettings);
 

diff --git a/com.unity.formats.fbx/Editor/Sources/Recorders/FbxRecorder/FbxRecorderSettings.cs b/com.unity.formats.fbx/Editor/Sources/Recorders/FbxRecorder/FbxRecorderSettings.cs
@@ -7,21 +7,8 @@
 namespace UnityEditor.Formats.Fbx.Exporter
 {
     [RecorderSettings(typeof(FbxRecorder), "FBX", "fbx_recorder")]
-    public class FbxRecorderSettings : RecorderSettings
+    internal class FbxRecorderSettings : RecorderSettings
     {
-        [SerializeField] bool m_exportGeometry = true;
-        public bool ExportGeometry
-        {
-            get
-            {
-                return m_exportGeometry;
-            }
-            set
-            {
-                m_exportGeometry = value;
-            }
-        }
-
         [SerializeField] AnimationInputSettings m_AnimationInputSettings = new AnimationInputSettings();
 
         public AnimationInputSettings animationInputSettings

diff --git a/com.unity.formats.fbx/Editor/Sources/Recorders/FbxRecorder/FbxRecorderSettingsEditor.cs b/com.unity.formats.fbx/Editor/Sources/Recorders/FbxRecorder/FbxRecorderSettingsEditor.cs
@@ -14,8 +14,6 @@ protected override void FileTypeAndFormatGUI()
             EditorGUILayout.LabelField("Format", "FBX");
 
             FbxRecorderSettings settings = target as FbxRecorderSettings;
-
-            settings.ExportGeometry = EditorGUILayout.Toggle("Export Geometry", settings.ExportGeometry);
         }
     }
 }