Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-1587: cleanup UX layout code. fix alignment for U6 #989

Merged
merged 34 commits into from
Jun 12, 2024

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented May 9, 2024

Purpose of this PR

Fix a number of UX issues:

  • A number of CM inspectors were not vertically aligned
  • Helpbox with button was messed up on U6
  • FreeLookModifier item foldout arrows were not visible
  • Moved some obsolete code in InspectorUtility to the obsolete folder (needed for CM2 support only)
  • Refactored the InspectorUtility layout helpers to support tabbing navigation
  • Hid the Legacy Targets member of TargetGroup
  • Refactored all the list views to no longer use bindItem, which changed behaviour as of 2023.3.31f1. This includes
    • SequencerCamera
    • StateDrivenCamera
    • CustomBlendSettings (in Brain and manager camera inspectors)
    • SplineRoll
    • SplineLookAtTargets
    • ChildCamera lists in all manager cameras

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested on U6 and 2022.3

@glabute glabute requested a review from AntoineCharton May 9, 2024 00:07
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

Attention: Patch coverage is 1.42180% with 624 lines in your changes missing coverage. Please review.

Project coverage is 26.97%. Comparing base (a53a196) to head (ba7c9ae).
Report is 2 commits behind head on main.

Files Patch % Lines
...achine/Editor/Obsolete/ObsoleteInspectorUtility.cs 0.00% 176 Missing ⚠️
...ity.cinemachine/Editor/Utility/InspectorUtility.cs 0.00% 92 Missing ⚠️
...itors/CinemachineSplineDollyLookAtTargetsEditor.cs 0.00% 85 Missing ⚠️
...hine/Editor/Editors/CinemachineSplineRollEditor.cs 0.00% 40 Missing ⚠️
...machine/Editor/Utility/CmCameraInspectorUtility.cs 0.00% 39 Missing ⚠️
...chine/Editor/Utility/SplineDataInspectorUtility.cs 0.00% 37 Missing ⚠️
...itor/Editors/CinemachineStateDrivenCameraEditor.cs 0.00% 33 Missing ⚠️
...Editor/Editors/CinemachineBlenderSettingsEditor.cs 0.00% 26 Missing ⚠️
...Editor/Editors/CinemachineSequencerCameraEditor.cs 0.00% 19 Missing ⚠️
...chine/Editor/Utility/EmbeddedAssetEditorUtility.cs 0.00% 14 Missing ⚠️
... and 21 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
- Coverage   26.98%   26.97%   -0.01%     
==========================================
  Files         253      254       +1     
  Lines       28405    28418      +13     
==========================================
+ Hits         7664     7665       +1     
- Misses      20741    20753      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glabute glabute changed the title CMCL-0000: cleanup UX layout code. fix alignment for U6 CMCL-1587: cleanup UX layout code. fix alignment for U6 May 9, 2024
@@ -158,7 +158,7 @@ public override void OnGUI(Rect rect, SerializedProperty property, GUIContent la
}
}

partial class InputAxisWithNamePropertyDrawer : PropertyDrawer
partial class InputAxisPropertyDrawer : PropertyDrawer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to rename an obsolete class?

@glabute
Copy link
Collaborator Author

glabute commented Jun 12, 2024

because it's partial and connects to a non-obsolete renamed class (which is internal in any case)

Copy link
Contributor

@AntoineCharton AntoineCharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we needed some changes on some internal deprecated classes?
Any thoughts on setting weight parameters on mixingCamera has NoSaveDuringPlay? It is prompting save on MixingCamera sample.
Other than that looks good tested on U6 and 2022.

@glabute glabute merged commit 5be26c8 into main Jun 12, 2024
9 checks passed
@glabute glabute deleted the dev/ux-layout-cleanup branch June 12, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants