-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMCL-1587: cleanup UX layout code. fix alignment for U6 #989
Conversation
@@ -158,7 +158,7 @@ public override void OnGUI(Rect rect, SerializedProperty property, GUIContent la | |||
} | |||
} | |||
|
|||
partial class InputAxisWithNamePropertyDrawer : PropertyDrawer | |||
partial class InputAxisPropertyDrawer : PropertyDrawer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to rename an obsolete class?
because it's partial and connects to a non-obsolete renamed class (which is internal in any case) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we needed some changes on some internal deprecated classes?
Any thoughts on setting weight parameters on mixingCamera has NoSaveDuringPlay? It is prompting save on MixingCamera sample.
Other than that looks good tested on U6 and 2022.
Purpose of this PR
Fix a number of UX issues:
bindItem
, which changed behaviour as of 2023.3.31f1. This includesTesting status