-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for charindex, dateadd, to_timestamp (DNA-19468 / DNA-20817) #84
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
with Input_data as ( | ||
select | ||
'This is a text!' as `Text` | ||
) | ||
|
||
select | ||
{# Find a substring (basic scenario) #} | ||
{{ pm_utils.charindex('his', '`Text`') }} as `Find_basic_scenario`, | ||
2 as `Find_basic_scenario_expected`, | ||
|
||
{# Find a substring with multiple occurences #} | ||
{{ pm_utils.charindex('is', '`Text`') }} as `Find_first_of_multiple_occurrences`, | ||
3 as `Find_first_of_multiple_occurrences_expected`, | ||
|
||
{# Find a space. Covering an edge case in SQL Server, spaces in values are ignored by default #} | ||
{{ pm_utils.charindex(' ', '`Text`') }} as `Find_first_space`, | ||
5 as `Find_first_space_expected`, | ||
|
||
{# Find a substring with multiple occurences using a start location after the first occurence #} | ||
{{ pm_utils.charindex('is', '`Text`', 4) }} as `Find_with_start_location`, | ||
6 as `Find_with_start_location_expected`, | ||
|
||
{# Find non occuring value #} | ||
{{ pm_utils.charindex('x', '`Text`') }} as `Find_non_occurring_value`, | ||
13 as `Find_non_occurring_value_expected`, | ||
|
||
{# Find empty value #} | ||
{{ pm_utils.charindex('', '`Text`') }} as `Find_empty_value`, | ||
0 as `Find_empty_value_expected`, | ||
|
||
{# Find null value #} | ||
{{ pm_utils.charindex(null, '`Text`') }} as `Find_null_value`, | ||
0 as `Find_null_value_expected` | ||
|
||
from Input_data |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
with Input_data as ( | ||
select | ||
'2023-11-12 13:14:15.678' as `testdate`, | ||
null as `null_value`, | ||
{{ pm_utils.to_integer('1') }} as `bigint_value` | ||
|
||
) | ||
|
||
select | ||
{# Add milliseconds, seconds, minutes, hours, days, months and years #} | ||
{{ pm_utils.to_varchar(pm_utils.dateadd('millisecond', 1, '`testdate`')) }} as `add_milliseconds`, | ||
{{ pm_utils.to_varchar(pm_utils.dateadd('second', 1, '`testdate`')) }} as `add_seconds`, | ||
{{ pm_utils.to_varchar(pm_utils.dateadd('minute', 1, '`testdate`')) }} as `add_minutes`, | ||
{{ pm_utils.to_varchar(pm_utils.dateadd('hour', 1, '`testdate`')) }} as `add_hours`, | ||
{{ pm_utils.to_varchar(pm_utils.dateadd('day', 1, '`testdate`')) }} as `add_days`, | ||
{{ pm_utils.to_varchar(pm_utils.dateadd('week', 1, '`testdate`')) }} as `add_weeks`, | ||
{{ pm_utils.to_varchar(pm_utils.dateadd('month', 1, '`testdate`')) }} as `add_months`, | ||
{{ pm_utils.to_varchar(pm_utils.dateadd('quarter', 1, '`testdate`')) }} as `add_quarters`, | ||
{{ pm_utils.to_varchar(pm_utils.dateadd('year', 1, '`testdate`')) }} as `add_years`, | ||
|
||
{# Use bigint as the value #} | ||
{{ pm_utils.to_varchar(pm_utils.dateadd('year', '`bigint_value`', '`testdate`')) }} as `add_bigint`, | ||
|
||
{% if target.type == 'sqlserver' %} | ||
{# SQL Server uses datetime2 format, which has a precision of 7 digits #} | ||
'2023-11-12 13:14:15.6790000' as `add_milliseconds_expected`, | ||
'2023-11-12 13:14:16.6780000' as `add_seconds_expected`, | ||
'2023-11-12 13:15:15.6780000' as `add_minutes_expected`, | ||
'2023-11-12 14:14:15.6780000' as `add_hours_expected`, | ||
'2023-11-13 13:14:15.6780000' as `add_days_expected`, | ||
'2023-11-19 13:14:15.6780000' as `add_weeks_expected`, | ||
'2023-12-12 13:14:15.6780000' as `add_months_expected`, | ||
'2024-02-12 13:14:15.6780000' as `add_quarters_expected`, | ||
'2024-11-12 13:14:15.6780000' as `add_years_expected`, | ||
'2024-11-12 13:14:15.6780000' as `add_bigint_expected`, | ||
{% else %} | ||
'2023-11-12 13:14:15.679' as `add_milliseconds_expected`, | ||
'2023-11-12 13:14:16.678' as `add_seconds_expected`, | ||
'2023-11-12 13:15:15.678' as `add_minutes_expected`, | ||
'2023-11-12 14:14:15.678' as `add_hours_expected`, | ||
'2023-11-13 13:14:15.678' as `add_days_expected`, | ||
'2023-11-19 13:14:15.678' as `add_weeks_expected`, | ||
'2023-12-12 13:14:15.678' as `add_months_expected`, | ||
'2024-02-12 13:14:15.678' as `add_quarters_expected`, | ||
'2024-11-12 13:14:15.678' as `add_years_expected`, | ||
'2024-11-12 13:14:15.678' as `add_bigint_expected`, | ||
{% endif %} | ||
|
||
{# Use null as the date #} | ||
{{ pm_utils.to_varchar(pm_utils.dateadd('year', 1, '`null_value`')) }} as `add_to_null_value`, | ||
'' as `add_to_null_value_expected` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Then this should also be a |
||
|
||
from Input_data |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
with Input_data as ( | ||
select | ||
'2023-11-12' as `timestamp_date`, | ||
'2023-11-12 13:14:15' as `timestamp_datetime`, | ||
'2023-11-12 13:14:15.678' as `timestamp_datetime_ms`, | ||
'2023-11-12 13:14:15.6789' as `timestamp_datetime_ms4`, | ||
'13:14:15' as `timestamp_time`, | ||
null as `null_value` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as before, shouldn't it be a datetime |
||
) | ||
|
||
select | ||
{{ pm_utils.to_varchar(pm_utils.to_timestamp('`timestamp_date`')) }} as `timestamp_date`, | ||
{{ pm_utils.to_varchar(pm_utils.to_timestamp('`timestamp_datetime`')) }} as `timestamp_datetime`, | ||
{{ pm_utils.to_varchar(pm_utils.to_timestamp('`timestamp_datetime_ms`')) }} as `timestamp_datetime_ms`, | ||
{{ pm_utils.to_varchar(pm_utils.to_timestamp('`timestamp_datetime_ms4`')) }} as `timestamp_datetime_ms4`, | ||
{{ pm_utils.to_varchar(pm_utils.to_timestamp('`timestamp_time`')) }} as `timestamp_time`, | ||
{{ pm_utils.to_varchar(pm_utils.to_timestamp('`null_value`')) }} as `null_value`, | ||
|
||
{% if target.type == 'databricks' %} | ||
'' as `timestamp_date_expected`, | ||
'2023-11-12 13:14:15' as `timestamp_datetime_expected`, | ||
'2023-11-12 13:14:15.678' as `timestamp_datetime_ms_expected`, | ||
'2023-11-12 13:14:15' as `timestamp_datetime_ms4_expected`, | ||
'' as `timestamp_time_expected`, | ||
'' as `null_value_expected` | ||
{% elif target.type == 'sqlserver' %} | ||
--SQL Server uses datetime2 format and always specifies the precision with 7 digits. | ||
--SQL Server will also give a result when only having a date or a time as input | ||
'2023-11-12 00:00:00.0000000' as `timestamp_date_expected`, | ||
'2023-11-12 13:14:15.0000000' as `timestamp_datetime_expected`, | ||
'2023-11-12 13:14:15.6780000' as `timestamp_datetime_ms_expected`, | ||
'2023-11-12 13:14:15.6789000' as `timestamp_datetime_ms4_expected`, | ||
'1900-01-01 13:14:15.0000000' as `timestamp_time_expected`, | ||
'' as `null_value_expected` | ||
{% elif target.type == 'snowflake' %} | ||
'' as `timestamp_date_expected`, | ||
'2023-11-12 13:14:15.000' as `timestamp_datetime_expected`, | ||
'2023-11-12 13:14:15.678' as `timestamp_datetime_ms_expected`, | ||
'2023-11-12 13:14:15.678' as `timestamp_datetime_ms4_expected`, | ||
'' as `timestamp_time_expected`, | ||
'' as `null_value_expected` | ||
{% endif %} | ||
|
||
from Input_data |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a datetime
NULL
value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically you are correct. We just removed the test for type tests from pm_utils. We can add it in the test and add Databricks support, but it is not compatible with Spark (no information_schema available). We discussed it and for now we will leave it this way, we will add a test if we run into an issue here.