Add integration tests for charindex, dateadd, to_timestamp (DNA-19468 / DNA-20817) #84
Conversation
Dennis-UiPath
force-pushed
the
test/add_integration_tests
branch
from
ef7adf5 to
d93ace3
Compare
| {{ pm_utils.charindex('is', '`Text`') }} as `Find_first_of_multiple_occurrences`, | ||
| 3 as `Find_first_of_multiple_occurrences_expected`, | ||
|
|
||
| {# Find a space. SQL Server handles spaces differently #} |
There was a problem hiding this comment.
It's true that SQL Server handles spaces differently, but that's applicable for the len function, not the charindex function. Maybe rephrase this?
There was a problem hiding this comment.
Updated the comment to cover it better
| {{ pm_utils.to_varchar(pm_utils.dateadd('year', 1, '`testdate`')) }} as `add_years`, | ||
|
|
||
| {# Use bigint as the value #} | ||
| {{ pm_utils.to_varchar(pm_utils.dateadd('year', '`bigint_value`', '`testdate`')) }} as `add_bigint`, |
There was a problem hiding this comment.
No test for this use case?
There was a problem hiding this comment.
Added the testcase here
| with Input_data as ( | ||
| select | ||
| '2023-11-12 13:14:15.678' as `testdate`, | ||
| null as `null_value`, |
There was a problem hiding this comment.
This should be a datetime NULL value.
There was a problem hiding this comment.
Technically you are correct. We just removed the test for type tests from pm_utils. We can add it in the test and add Databricks support, but it is not compatible with Spark (no information_schema available). We discussed it and for now we will leave it this way, we will add a test if we run into an issue here.
|
|
||
| {# Use null as the date #} | ||
| {{ pm_utils.to_varchar(pm_utils.dateadd('year', 1, '`null_value`')) }} as `add_to_null_value`, | ||
| '' as `add_to_null_value_expected` |
There was a problem hiding this comment.
Then this should also be a NULL datetime/date? 🤔
| '2023-11-12 13:14:15.678' as `timestamp_datetime_ms`, | ||
| '2023-11-12 13:14:15.6789' as `timestamp_datetime_ms4`, | ||
| '13:14:15' as `timestamp_time`, | ||
| null as `null_value` |
There was a problem hiding this comment.
Same as before, shouldn't it be a datetime NULL?
Dennis-UiPath
force-pushed
the
test/add_integration_tests
branch
from
d93ace3 to
35e6ec3
Compare
Description
charindex,dateaddandto_timestampmacro'sRelease
main)dev(or other) branchDid you consider?
- [ ] What is the performance impact?- [ ] The version number indbt_project.yml