Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing and checking commits #13

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

StaticRocket
Copy link
Member

@StaticRocket StaticRocket commented Oct 24, 2024

Add a short file detailing how one can contribute to the project.

Add a commit check for PRs to make sure they are following the rules outlined in the CONTRIBUTING document.

Resolves #6
Resolves #10

@StaticRocket
Copy link
Member Author

@nmenon

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@StaticRocket StaticRocket force-pushed the check-commits branch 2 times, most recently from 29140fa to 414aaa6 Compare October 25, 2024 20:09
@StaticRocket StaticRocket requested a review from nmenon October 25, 2024 20:34
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@cshilwant
Copy link
Member

Hmm, Looks like conventional commit doesn't like more than 1 colon in commit message title - https://github.com/TexasInstruments/processor-sdk-doc/actions/runs/11524739733/attempts/1#summary-32085557172

@StaticRocket StaticRocket force-pushed the check-commits branch 2 times, most recently from 6219fb2 to e508d78 Compare October 25, 2024 23:28
@cshilwant
Copy link
Member

The bots looks super strict - https://github.com/StaticRocket/processor-sdk-doc/actions/runs/11526783806/attempts/1#summary-32091486204

Has a restriction in branch name as well

@nmenon
Copy link
Contributor

nmenon commented Oct 25, 2024

I must say, I LOVE IT!

@StaticRocket
Copy link
Member Author

Yeah, but that's more for filtering branches on the primary repo, which there shouldn't really be anything other than master unless we decide to do some massive work that requires multiple contributions.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@nmenon
Copy link
Contributor

nmenon commented Oct 26, 2024

Probably not on this commit, but we should consider adding something like https://blog.alta3.com/topics/scm-and-pipelines/adding-spell-checking-as-a-github-action/ -> I wonder if github enterprise has a paid service for grammar and spell check

Add a short file detailing how one can contribute to the project.

Signed-off-by: Randolph Sapp <[email protected]>
Add a commit check for PRs to make sure they are following the rules
outlined in the CONTRIBUTING document.

Signed-off-by: Randolph Sapp <[email protected]>
CONTRIBUTING.md Show resolved Hide resolved
@cshilwant
Copy link
Member

Yeah, but that's more for filtering branches on the primary repo, which there shouldn't really be anything other than master unless we decide to do some massive work that requires multiple contributions.

I was referring to the branch names it expects from the author creating PRs as well.
Branches must begin with these types: bugfix/ feature/ release/ hotfix/

@nmenon
Copy link
Contributor

nmenon commented Oct 26, 2024

Also, please edit $subject line of PR: s/Contibuting/Contributing so that the merge message looks clean.

@StaticRocket StaticRocket changed the title Contibuting and checking commits Contributing and checking commits Oct 26, 2024
@StaticRocket
Copy link
Member Author

I wonder if github enterprise has a paid service for grammar and spell check

I was thinking about that, but considering all the acronyms and odd names we'd definitely need to make our own dictionary for it to be useful. That being said, if we actually did make an acronym and odd word dict, it would make for good appendix fodder.

@StaticRocket StaticRocket merged commit 6c23996 into TexasInstruments:master Oct 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code scanning provide a documentation contribution guidelines doc
4 participants