Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default accessibility parameters to send alongside each request #212

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

Jeehut
Copy link
Contributor

@Jeehut Jeehut commented Dec 1, 2024

Fixes #105

@Jeehut Jeehut requested a review from winsmith December 1, 2024 13:55
@Jeehut Jeehut force-pushed the feature/accessibility branch from e6b845f to df4a802 Compare December 1, 2024 16:15
@Jeehut Jeehut force-pushed the feature/accessibility branch from df4a802 to 6e49fc6 Compare December 1, 2024 16:35
Copy link
Contributor

@winsmith winsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! I think we'll need to make sure all of these are documented, not only for our customers, but also for internal use.

For example, we have various server optimizations now that work better if we know what parameters an event can have. We can then also set these to different data types if necessary.

I'll think about how we can integrate this into the docs in a smart way.

@Jeehut Jeehut merged commit e1818e7 into main Dec 2, 2024
6 checks passed
@Jeehut Jeehut deleted the feature/accessibility branch December 2, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically send a11y stats
2 participants