Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add screen scale factor on iOS, macOS, and tvOS for proper pixels #213

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Add screen scale factor on iOS, macOS, and tvOS for proper pixels #213

merged 1 commit into from
Dec 2, 2024

Conversation

Jeehut
Copy link
Contributor

@Jeehut Jeehut commented Dec 1, 2024

Fixes #210

@Jeehut Jeehut mentioned this pull request Dec 1, 2024
Closed
@Jeehut Jeehut requested a review from winsmith December 1, 2024 14:32
winsmith
winsmith approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@winsmith winsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! As with #212, I'll make a note to make sure these can be accepted as numerical values instead of strings on the server

@Jeehut Jeehut merged commit f6630c6 into main Dec 2, 2024
6 checks passed
@Jeehut Jeehut deleted the feature/scale-factor branch December 2, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winsmith winsmith winsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: add display scale factor to default parameters
2 participants
@Jeehut @winsmith