Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update_membership() keeping outdated scores #61

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

Syriiin
Copy link
Owner

@Syriiin Syriiin commented Jun 2, 2024

Why?

There are cases where a score might be removed from a membership.
The usual case for this is when the member supercedes it with a better score on the same beatmap.
This can also happen if there are bugs that cause incorrect scores to get added in the first place, or the leaderboard score filter is manually adjusted.
Either way, we want update_membership() to ensure the membership is fully valid and up to date, including scores.

Changes

  • Remove outdated scores from memberships in update_membership()

@Syriiin Syriiin merged commit 5916bed into master Jun 2, 2024
3 checks passed
@Syriiin Syriiin deleted the fix/outdated-membership-scores branch June 2, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant