Merge pull request #61 from Syriiin/fix/outdated-membership-scores

Fix update_membership() keeping outdated scores
Syriiin · Jun 2, 2024 · 5916bed · 5916bed
2 parents 3bce099 + 55e133d
commit 5916bed
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/leaderboards/services.py b/leaderboards/services.py
@@ -119,6 +119,11 @@ def get_performance_total(score: Score, score_set: ScoreSet):
         unique_fields=["membership_id", "score_id"],
     )
 
+    outdated_membershipscores = MembershipScore.objects.filter(
+        membership=membership
+    ).exclude(score_id__in=[score.id for score in scores])
+    outdated_membershipscores.delete()
+
     membership.score_count = len(membership_scores)
 
     membership.pp = calculate_pp_total(